From: Stephan Gatzka <stephan.gatzka@gmail.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
netdev@vger.kernel.org, linux1394-devel@lists.sourceforge.net
Subject: Re: [RFC PATCH 6/6] ipv6: IPv6 over IEEE1394 (RFC3146) support.
Date: Sat, 12 Jan 2013 15:40:27 +0100 [thread overview]
Message-ID: <50F175DB.5050400@gmail.com> (raw)
In-Reply-To: <50F17178.3090705@linux-ipv6.org>
That looks good to me and is more or less exactly I wanted to do.
> diff --git a/include/net/ndisc.h b/include/net/ndisc.h
> index 3c53257..1de4e0c 100644
> --- a/include/net/ndisc.h
> +++ b/include/net/ndisc.h
> @@ -52,6 +52,7 @@ enum {
> #include <linux/hash.h>
>
> #include <net/neighbour.h>
> +#include <net/firewire.h>
-- snip --
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index 99cd286..9a0ba9c 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -72,6 +72,8 @@
> #include <linux/netfilter.h>
> #include <linux/netfilter_ipv6.h>
>
> +#include <net/firewire.h>
-- snip --
But now we have to include firewire.h in the ndisc code. The advantage
is that we the firewire_net structure is now private.
Regards,
Stephan
next prev parent reply other threads:[~2013-01-12 14:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-12 14:21 [RFC PATCH 6/6] ipv6: IPv6 over IEEE1394 (RFC3146) support YOSHIFUJI Hideaki
2013-01-12 14:40 ` Stephan Gatzka [this message]
2013-01-12 15:47 ` Stefan Richter
2013-01-12 16:37 ` Stephan Gatzka
2013-01-12 16:39 ` YOSHIFUJI Hideaki
2013-01-12 16:44 ` Stephan Gatzka
2013-01-13 3:57 ` YOSHIFUJI Hideaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F175DB.5050400@gmail.com \
--to=stephan.gatzka@gmail.com \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).