From: John Fastabend <john.r.fastabend@intel.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] net: Export __netdev_pick_tx so that it can be used in modules
Date: Sun, 13 Jan 2013 09:27:16 -0800 [thread overview]
Message-ID: <50F2EE74.6080207@intel.com> (raw)
In-Reply-To: <50F0902B.5060500@intel.com>
On 1/11/2013 2:20 PM, Alexander Duyck wrote:
> On 01/11/2013 11:02 AM, John Fastabend wrote:
>> On 1/11/2013 10:38 AM, Alexander Duyck wrote:
>>> When testing with FCoE enabled we discovered that I had not exported
>>> __netdev_pick_tx. As a result ixgbe doesn't build with the RFC patches
>>> applied because ixgbe_select_queue was calling the function. This change
>>> corrects that build issue by correctly exporting __netdev_pick_tx so it
>>> can be used by modules.
>>>
>>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
>>> ---
>>
>> Hi Alex,
>>
>> If we get XPS to play nicely with the traffic class schemes we
>> can just remove select_queue completely.
>>
>> I'll take a look tomorrow.
>>
>> Thanks,
>> John
>
> Hi John,
>
> It would be great if we could drop it entirely.
>
> I just to make sure we are on the same page. What you are saying is
> that we could do that in addition to this patch correct? I'm pretty
Yes correct an additional patch on top of your work. This patch series
just got me thinking about it again.
.John
next prev parent reply other threads:[~2013-01-13 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-11 18:38 [PATCH] net: Export __netdev_pick_tx so that it can be used in modules Alexander Duyck
2013-01-11 19:02 ` John Fastabend
2013-01-11 22:20 ` Alexander Duyck
2013-01-13 17:27 ` John Fastabend [this message]
2013-01-11 23:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F2EE74.6080207@intel.com \
--to=john.r.fastabend@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).