From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, roland@purestorage.com,
Eric Dumazet <eric.dumazet@gmail.com>,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [RFC Patch net-next] ipv6: look up neighbours on demand in ip6_finish_output2()
Date: Tue, 15 Jan 2013 21:22:33 +0900 [thread overview]
Message-ID: <50F54A09.2040206@linux-ipv6.org> (raw)
In-Reply-To: <50F4BEB2.2050201@gmail.com>
Cong Wang wrote:
> On 01/15/2013 02:30 AM, David Miller wrote:
>>
>> This is a very incomplete patch.
>>
>> If this change were so simple, it would have been done by someone
>> else a long time ago.
>>
>> You must, in addition to the incredibly obvious changes in the packet
>> output path, completely eliminate the caching of the neighbour entry
>> in the ipv6 routes themselves.
>>
>> This means replacing every rt6->n access or test with something
>> equivalent.
>>
>
> THanks, David and Eric!
>
> I knew this is probably incomplete, that is why I added "RFC". Fortunately, YOSHIFUJI just sent a more complete patch:
>
> [RFC net-next] ipv6 route: Do not attach neighbour on route.
>
> So, please ignore mine and use his. :)
Well, in fact, it did't work. Tt really needs further work.
--yoshfuji
prev parent reply other threads:[~2013-01-15 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 13:35 [RFC Patch net-next] ipv6: look up neighbours on demand in ip6_finish_output2() Cong Wang
2013-01-14 16:29 ` Eric Dumazet
2013-01-14 18:30 ` David Miller
2013-01-15 2:28 ` Cong Wang
2013-01-15 12:22 ` YOSHIFUJI Hideaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F54A09.2040206@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roland@purestorage.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).