From: Cong Wang <xiyou.wangcong@gmail.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC(v2) net-next 08/13] ipv6: Do not deoend on rt->n in ip6_dst_lookup_tail().
Date: Wed, 16 Jan 2013 14:49:58 +0800 [thread overview]
Message-ID: <50F64D96.4090709@gmail.com> (raw)
In-Reply-To: <50F587CF.1090306@linux-ipv6.org>
s/deoend/depend/ in $subject...
On 01/16/2013 12:46 AM, YOSHIFUJI Hideaki wrote:
> Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> ---
> net/ipv6/ip6_output.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv6/ip6_output.c b/net/ipv6/ip6_output.c
> index 9fc5d1d..b2fe048 100644
> --- a/net/ipv6/ip6_output.c
> +++ b/net/ipv6/ip6_output.c
> @@ -921,8 +921,12 @@ static int ip6_dst_lookup_tail(struct sock *sk,
> * dst entry of the nexthop router
> */
> rt = (struct rt6_info *) *dst;
> - n = rt->n;
> - if (n && !(n->nud_state & NUD_VALID)) {
> + rcu_read_lock_bh();
> + n = __ipv6_neigh_lookup_noref(rt->dst.dev, rt6_nexthop(rt, &fl6->daddr));
> + err = n && !(n->nud_state & NUD_VALID) ? -EINVAL : 0;
> + rcu_read_unlock_bh();
> +
> + if (err) {
Are you sure the logic here equals?
In the original code, we could return 0 even we enter this if branch,
but after your patch, it seems it will return -EINVAL?
next prev parent reply other threads:[~2013-01-16 6:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 16:46 [RFC(v2) net-next 08/13] ipv6: Do not deoend on rt->n in ip6_dst_lookup_tail() YOSHIFUJI Hideaki
2013-01-16 6:49 ` Cong Wang [this message]
2013-01-16 12:27 ` YOSHIFUJI Hideaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50F64D96.4090709@gmail.com \
--to=xiyou.wangcong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).