From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: stephan.gatzka@gmail.com
Cc: Stefan Richter <stefanr@s5r6.in-berlin.de>,
linux1394-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Subject: Re: [PATCH] firewire net: Ensure checksumming in upper layer.
Date: Mon, 21 Jan 2013 00:10:29 +0900 [thread overview]
Message-ID: <50FC08E5.6020903@linux-ipv6.org> (raw)
In-Reply-To: <50FC0353.8090902@gmail.com>
Stephan Gatzka wrote:
>
>>> Indeed neither the device nor the lower drivers check protocol checksums.
>>> But the CRCs of the encapsulating 1394 packets are checked in hardware.
>>> Shall protocol checksums be verified regardless?
>>
>> Yes, because packets may come from off-link source.
>>
>
> Hm, I can't see any off-link packets coming from fwnet_finish_incoming_packet()
>
> So I wont verify checksums in the driver.
"Off-link source" means the source exists on the different L2
network. In other words, source is connected via router(s).
ethernet firewire
Host -------------- Router ------------ Host
--yoshfuji
next prev parent reply other threads:[~2013-01-20 15:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 7:43 [PATCH] firewire net: Ensure checksumming in upper layer YOSHIFUJI Hideaki
2013-01-20 9:50 ` Stefan Richter
2013-01-20 10:37 ` YOSHIFUJI Hideaki
2013-01-20 14:46 ` Stephan Gatzka
2013-01-20 15:10 ` YOSHIFUJI Hideaki [this message]
2013-01-20 15:17 ` Stephan Gatzka
2013-01-20 15:48 ` YOSHIFUJI Hideaki
2013-01-21 4:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FC08E5.6020903@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
--cc=stephan.gatzka@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).