netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephan Gatzka <stephan.gatzka@gmail.com>
To: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Cc: netdev@vger.kernel.org,
	Stefan Richter <stefanr@s5r6.in-berlin.de>,
	linux1394-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire net: Ensure checksumming in upper layer.
Date: Sun, 20 Jan 2013 16:17:00 +0100	[thread overview]
Message-ID: <50FC0A6C.205@gmail.com> (raw)
In-Reply-To: <50FC08E5.6020903@linux-ipv6.org>


> "Off-link source" means the source exists on the different L2
> network.  In other words, source is connected via router(s).
>
>           ethernet             firewire
>   Host -------------- Router ------------ Host
>

O.k., understood. But the receiving router verifies the checksum of 
incoming packets and sends them on the firewire link. On firewire we 
have CRC checksums to ensure the integrity of packets.

I agree with your patch but I don't see why we should check them in the 
driver. I thought your patch will ensure that the checksums will be 
verified in the upper layers.

Stephan

------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnmore_123012

  reply	other threads:[~2013-01-20 15:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-20  7:43 [PATCH] firewire net: Ensure checksumming in upper layer YOSHIFUJI Hideaki
2013-01-20  9:50 ` Stefan Richter
2013-01-20 10:37   ` YOSHIFUJI Hideaki
2013-01-20 14:46     ` Stephan Gatzka
2013-01-20 15:10       ` YOSHIFUJI Hideaki
2013-01-20 15:17         ` Stephan Gatzka [this message]
2013-01-20 15:48           ` YOSHIFUJI Hideaki
2013-01-21  4:16 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FC0A6C.205@gmail.com \
    --to=stephan.gatzka@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).