From: Li Yu <raise.sail@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: brutus@google.com, netdev@vger.kernel.org
Subject: Re: v3 for tcp friends?
Date: Mon, 21 Jan 2013 15:29:40 +0800 [thread overview]
Message-ID: <50FCEE64.80203@gmail.com> (raw)
In-Reply-To: <20120904.125841.2293649688957878987.davem@davemloft.net>
于 2012年09月05日 00:58, David Miller 写道:
> From: Bruce Curtis <brutus@google.com>
> Date: Tue, 4 Sep 2012 08:10:23 -0700
>
>> Will do, issues addressed, I'll get the patch out later today or
>> tomorrow at the latest.
>
> Thanks a lot Bruce.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
Hi, Bruce,
I tested the TCP friends, found a bug here:
[ 106.541372] Pid: 1765, comm: client Not tainted 3.7.0-rc1+ #25
[ 106.543121] Call Trace:
[ 106.543950] [<ffffffff8133d212>] inet_sock_destruct+0x102/0x1f0
[ 106.545687] [<ffffffff812c38ad>] __sk_free+0x1d/0x110
[ 106.547209] [<ffffffff812c3a1c>] sk_free+0x1c/0x20
[ 106.548611] [<ffffffff8131680c>] tcp_close+0x6c/0x3f0
[ 106.549863] [<ffffffff8133caea>] inet_release+0xda/0xf0
[ 106.551134] [<ffffffff8133ca30>] ? inet_release+0x20/0xf0
[ 106.552419] [<ffffffff8137f3de>] ? mutex_unlock+0xe/0x10
[ 106.553658] [<ffffffff812bf948>] sock_release+0x28/0xa0
[ 106.557366] [<ffffffff812bfd69>] sock_close+0x29/0x30
[ 106.558831] [<ffffffff81128972>] __fput+0x122/0x210
[ 106.560541] [<ffffffff81128a6e>] ____fput+0xe/0x10
[ 106.562006] [<ffffffff8105354e>] task_work_run+0x9e/0xd0
[ 106.563285] [<ffffffff810027e1>] do_notify_resume+0x61/0x70
[ 106.564582] [<ffffffff8138a908>] int_signal+0x12/0x17
I also backported and tested it on stable kernel 3.7.3/RHEL6
kernel, this bug still exists. It seem that client may close listening
sockets, may we need to add one reference count for listen socket
before send its address to peer?
And, our TCP friends v4? :)
Thanks
Yu
next prev parent reply other threads:[~2013-01-21 7:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 19:48 v3 for tcp friends? David Miller
2012-09-04 15:10 ` Bruce Curtis
2012-09-04 16:58 ` David Miller
2013-01-21 7:29 ` Li Yu [this message]
2013-01-21 7:31 ` Li Yu
[not found] ` <CA+WLrf8xuJ3UXK-tZQykuTPMXu67WsNKWNuNzBKk7MBAidW-CQ@mail.gmail.com>
[not found] ` <CAEkNxbH0MAAU9oiwwrFTbMJP1yzfNdxD5NDdZOqGnvhTLvodoQ@mail.gmail.com>
2013-01-23 3:14 ` Li Yu
2013-01-23 6:12 ` Li Yu
2013-01-23 6:46 ` Eric Dumazet
2013-01-23 7:21 ` Li Yu
2013-01-23 7:58 ` Li Yu
2013-01-23 9:39 ` Li Yu
2013-01-23 9:52 ` Li Yu
2013-01-23 13:16 ` Weiping Pan
2013-01-24 2:04 ` Xiaotian Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50FCEE64.80203@gmail.com \
--to=raise.sail@gmail.com \
--cc=brutus@google.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).