netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext()
Date: Tue, 22 Jan 2013 13:07:27 -0800	[thread overview]
Message-ID: <50FEFF8F.40304@intel.com> (raw)
In-Reply-To: <1358886835.2892.14.camel@bwh-desktop.uk.solarflarecom.com>

On 01/22/2013 12:33 PM, Ben Hutchings wrote:
> Previously only the lower 32 bits would be shown.
> 
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
> ---
> I just noticed this bug when applying Yan Burman's patch.  Untested
> since sfc doesn't support this field.
> 
> Ben.
> 
>  rxclass.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/rxclass.c b/rxclass.c
> index 1564b62..cd686a3 100644
> --- a/rxclass.c
> +++ b/rxclass.c
> @@ -49,7 +49,7 @@ static void rxclass_print_nfc_spec_ext(struct ethtool_rx_flow_spec *fsp)
>  		tci = ntohs(fsp->h_ext.vlan_tci);
>  		tcim = ntohs(~fsp->m_ext.vlan_tci);
>  		data = (u64)ntohl(fsp->h_ext.data[0]) << 32;
> -		data = (u64)ntohl(fsp->h_ext.data[1]);
> +		data |= (u64)ntohl(fsp->h_ext.data[1]);
>  		datam = (u64)ntohl(~fsp->m_ext.data[0]) << 32;
>  		datam |= (u64)ntohl(~fsp->m_ext.data[1]);
>  
> 

This looks fine to me.  We didn't use data[0] in ixgbe so we never
noticed this either.

Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>

      reply	other threads:[~2013-01-22 21:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-22 20:33 [PATCH ethtool] rxclass: Show full 64 bits of user-data in rxclass_print_nfc_spec_ext() Ben Hutchings
2013-01-22 21:07 ` Alexander Duyck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FEFF8F.40304@intel.com \
    --to=alexander.h.duyck@intel.com \
    --cc=bhutchings@solarflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).