From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] rtnetlink: invoke 'cb->done' destructor before 'cb->args' reset Date: Wed, 31 Oct 2018 11:35:31 -0600 Message-ID: <50d88abb-bfba-6c70-af68-7bac60a0d4b1@gmail.com> References: <1540968178-18894-1-git-send-email-alexey.kodanev@oracle.com> <104f12e4-866b-b986-cb9d-28c40d5c5e84@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: David Miller To: Alexey Kodanev , netdev@vger.kernel.org Return-path: Received: from mail-pf1-f196.google.com ([209.85.210.196]:38001 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729737AbeKACed (ORCPT ); Wed, 31 Oct 2018 22:34:33 -0400 Received: by mail-pf1-f196.google.com with SMTP id b11-v6so7951742pfi.5 for ; Wed, 31 Oct 2018 10:35:35 -0700 (PDT) In-Reply-To: <104f12e4-866b-b986-cb9d-28c40d5c5e84@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/31/18 10:55 AM, David Ahern wrote: > I think the simplest fix for 4.20 is to break the loop if ret is non-0 - > restore the previous behavior. that is the only recourse. It has to bail if ret is non-0. Do you want to send a patch with that fix?