From mboxrd@z Thu Jan 1 00:00:00 1970 From: Murali Krishna Policharla Subject: RE: [PATCH] net: core: Fix to store new mtu setting in netdevice. Date: Thu, 3 Jan 2019 15:24:48 +0530 Message-ID: <50f99989b763da1cd630e0abf3ed940a@mail.gmail.com> References: <1546324934-17555-1-git-send-email-murali.policharla@broadcom.com> <20190101083450.GA17613@lunn.ch> <30ecb54251911d28c50b61299b0f8d3d@mail.gmail.com> <20190101232443.GA22737@lunn.ch> <20190102131657.GE22737@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Cc: Heiner Kallweit , davem@davemloft.net, amritha.nambiar@intel.com, ecree@solarflare.com, ktkhai@virtuozzo.com, alexander.h.duyck@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Andrew Lunn Return-path: In-Reply-To: <20190102131657.GE22737@lunn.ch> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org > Hi Andrew/Heiner > > Thanks for the feedback. This patch > fixes a case where ndo_change_mtu function is provided but the callback > function is not storing mtu to netdevice structure. > Hi Murali > At the moment, any driver which implements ndo_change_mtu MUST set > ndev->mtu. It is a nice clean definition, easy for any driver write to > understand. Hi Andrew Since drivers implementing ndo_change_mtu callback function are following this approach. Will go with the existing approach and modify the ndo_change_mtu callback function that I will be adding to store mtu to netdevice structure. Thanks Murali