From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F27C432BE for ; Wed, 11 Aug 2021 14:31:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4C7FC60E78 for ; Wed, 11 Aug 2021 14:31:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232503AbhHKOby (ORCPT ); Wed, 11 Aug 2021 10:31:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:42485 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232419AbhHKObw (ORCPT ); Wed, 11 Aug 2021 10:31:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628692284; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IMsaF6YNRWgvZkKD/Bb4KAtHQ1t58EnxtwdMzN8DDjs=; b=Dca7aWaOz0y7CbKcv2EqKUYKyiheKTiWygl50xldfM+zU/szWNF+Wtu6X1bqNkD4MNLwkF BQoEGJeyo3mQTZWkojtw2/8fIyLgtDw8i1YI/TRvV0fm9NWa+6Dw05alpURNLwdVD5a518 zqC3xRMlzFH3wYzHH6WZ8oYaF8BVJyA= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-x6Z-38qRM769GaJeC83gOg-1; Wed, 11 Aug 2021 10:31:23 -0400 X-MC-Unique: x6Z-38qRM769GaJeC83gOg-1 Received: by mail-qv1-f71.google.com with SMTP id z8-20020a0ce9880000b02903528f1b338aso1376308qvn.6 for ; Wed, 11 Aug 2021 07:31:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IMsaF6YNRWgvZkKD/Bb4KAtHQ1t58EnxtwdMzN8DDjs=; b=rk5rA/OeQJq4XnSwAznvfPwZTBq3IY/lkHVuIdWPw67enZ/n5pOg+Hoe7lP9/RqwpL Sr4hMWlZtRAH/mncjgnkwlenj6sdJ5zfAsQ75HzCkJelwAoERGLLt7BMQo+59Wjx0WD/ gSn9xle94ml6hMmGob0PnwGEQltKKJ3Oq0Eaa2azGu3LGNx4eXSCEKPPpOXdeigBx8mk NiVMcXtaEF6EqwzC2TKpoc0NCATU2UwINQMQNbnuQlCLNmh7HH1U2c0BMNdJqsS4dJwv SL2bvWOH9PFnRTJfEvAeZUtQb0ZOEUWyQz+qgeGQapPO4DrcGfZYzWjpSSmOonZOd+4R vwgg== X-Gm-Message-State: AOAM532vUfKioz6Qffo2N4aDRshQFAcMBb67ZGqw9rC6Ai+CvYysWwXv WCF/7Gjl0YnEzlcJen0NLl+aRNH2wsr+QgmnHxqB6qOAGFhFaR5tR9kHS8MXIp+HHjSK4I0THPh OhbSUUZstadPt8C6z X-Received: by 2002:ac8:7207:: with SMTP id a7mr30353234qtp.32.1628692282674; Wed, 11 Aug 2021 07:31:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwRN7N9t97BDNGO5cfSC1+itLxk34dUt1bOU5m035sou0qCpLmrUNFjMm8hxm8bwlwn0p2haw== X-Received: by 2002:ac8:7207:: with SMTP id a7mr30353215qtp.32.1628692282500; Wed, 11 Aug 2021 07:31:22 -0700 (PDT) Received: from jtoppins.rdu.csb ([107.15.110.69]) by smtp.gmail.com with ESMTPSA id q11sm12219443qkm.56.2021.08.11.07.31.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 07:31:22 -0700 (PDT) Subject: Re: [PATCH net-next v2 2/2] bonding: combine netlink and console error messages To: Joe Perches , Jakub Kicinski Cc: netdev@vger.kernel.org, leon@kernel.org, Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , linux-kernel@vger.kernel.org References: <20210811054917.722bd988@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Jonathan Toppins Message-ID: <5100eeab-dd01-d739-95f0-0a0267652bae@redhat.com> Date: Wed, 11 Aug 2021 10:31:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/11/21 9:23 AM, Joe Perches wrote: > On Wed, 2021-08-11 at 05:49 -0700, Jakub Kicinski wrote: >> On Tue, 10 Aug 2021 20:27:01 -0700 Joe Perches wrote: >>>> +#define BOND_NL_ERR(bond_dev, extack, errmsg) do { \ >>>> + if (extack) \ >>>> + NL_SET_ERR_MSG(extack, errmsg); \ >>>> + else \ >>>> + netdev_err(bond_dev, "Error: %s\n", errmsg); \ >>>> +} while (0) >>>> + >>>> +#define SLAVE_NL_ERR(bond_dev, slave_dev, extack, errmsg) do { \ >>>> + if (extack) \ >>>> + NL_SET_ERR_MSG(extack, errmsg); \ >>>> + else \ >>>> + slave_err(bond_dev, slave_dev, "Error: %s\n", errmsg); \ >>>> +} while (0) >>> >>> Ideally both of these would be static functions and not macros. >> >> That may break our ability for NL_SET_ERR_MSG to place strings >> back in a static buffer, no? > > Not really. > > The most common way to place things in a particular section is to > use __section("whatever") > > It's pretty trivial to mark these errmsg strings as above. I am unable to convert these to functions at this time, due to how NL_SET_ERR_MSG is expanded. This is with either a param list prototype of, "const char *errmsg" or "const char errmsg[]". $ make C=1 drivers/net/bonding/bonding.ko CALL scripts/checksyscalls.sh CALL scripts/atomic/check-atomics.sh DESCEND objtool DESCEND bpf/resolve_btfids CC [M] drivers/net/bonding/bond_main.o In file included from ./include/uapi/linux/neighbour.h:6, from ./include/linux/netdevice.h:45, from ./include/net/inet_sock.h:19, from ./include/net/ip.h:28, from drivers/net/bonding/bond_main.c:42: drivers/net/bonding/bond_main.c: In function ‘bond_nl_err’: drivers/net/bonding/bond_main.c:1733:26: error: invalid initializer NL_SET_ERR_MSG(extack, errmsg); ^~~~~~ ./include/linux/netlink.h:92:30: note: in definition of macro ‘NL_SET_ERR_MSG’ static const char __msg[] = msg; \ ^~~ drivers/net/bonding/bond_main.c: In function ‘slave_nl_err’: drivers/net/bonding/bond_main.c:1744:26: error: invalid initializer NL_SET_ERR_MSG(extack, errmsg); ^~~~~~ ./include/linux/netlink.h:92:30: note: in definition of macro ‘NL_SET_ERR_MSG’ static const char __msg[] = msg; \ ^~~ make[3]: *** [scripts/Makefile.build:271: drivers/net/bonding/bond_main.o] Error 1 make[2]: *** [scripts/Makefile.build:514: drivers/net/bonding] Error 2 make[1]: *** [scripts/Makefile.build:514: drivers/net] Error 2 make: *** [Makefile:1841: drivers] Error 2