From: Nivedita Singhvi <niveditasinghvi@gmail.com>
To: Vijay Subramanian <subramanian.vijay@gmail.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Leandro Lucarella <leandro.lucarella@sociomantic.com>,
Nivedita Singhvi <niv@us.ibm.com>
Subject: Re: [PATCH] tcp: Increment of LINUX_MIB_LISTENOVERFLOWS in tcp_v4_conn_request()
Date: Thu, 24 Jan 2013 23:41:54 -0800 [thread overview]
Message-ID: <51023742.2000908@gmail.com> (raw)
In-Reply-To: <CAGK4HS8ABKqa8J1Sd1Q52P4p3=KcSokQQX0e90FWV6aZsVdP3A@mail.gmail.com>
On 01/24/2013 11:29 PM, Vijay Subramanian wrote:
> On 24 January 2013 23:03, Nivedita Singhvi <niveditasinghvi@gmail.com> wrote:
>> We drop a connection request if the accept backlog, syn queue are full when processing reaches tcp_v4_conn_request(). Increment the appropriate counter so this isn't silent, for accurate stats and help in debugging.
>>
>
> Commit message seems misleading. syn queue is not really full at this
> point. It just has more than enough entries.
Er, good point. I should have said "sufficiently full" or "warm
enough to warrant starting drops" - hope I'm not confusing
things further, am I? DaveM, would you like me to resend, if you're
picking this up?
thanks,
Nivedita
next prev parent reply other threads:[~2013-01-25 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 7:03 [PATCH] tcp: Increment of LINUX_MIB_LISTENOVERFLOWS in tcp_v4_conn_request() Nivedita Singhvi
2013-01-25 7:29 ` Vijay Subramanian
2013-01-25 7:41 ` Nivedita Singhvi [this message]
2013-01-27 6:41 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51023742.2000908@gmail.com \
--to=niveditasinghvi@gmail.com \
--cc=davem@davemloft.net \
--cc=leandro.lucarella@sociomantic.com \
--cc=netdev@vger.kernel.org \
--cc=niv@us.ibm.com \
--cc=subramanian.vijay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).