From: Stephen Boyd <sboyd@codeaurora.org>
To: Felipe Balbi <balbi@ti.com>
Cc: davem@davemloft.net, mjr@cs.wisc.edu, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ks8851: convert to threaded IRQ
Date: Tue, 29 Jan 2013 10:53:08 -0800 [thread overview]
Message-ID: <51081A94.1090202@codeaurora.org> (raw)
In-Reply-To: <1359443790-8562-1-git-send-email-balbi@ti.com>
On 01/28/13 23:16, Felipe Balbi wrote:
> just as it should have been. It also helps
> removing the, now unnecessary, workqueue.
Tested-by: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> @@ -1505,8 +1485,9 @@ static int ks8851_probe(struct spi_device *spi)
> ks8851_read_selftest(ks);
> ks8851_init_mac(ks);
>
> - ret = request_irq(spi->irq, ks8851_irq, IRQF_TRIGGER_LOW,
> - ndev->name, ks);
> + ret = request_threaded_irq(spi->irq, NULL, ks8851_irq,
> + IRQF_TRIGGER_LOW | IRQF_ONESHOT,
> + ndev->name, ks);
I did notice one thing here. The name of the thread is irq/378-eth%d
(where 378 is the irq number). It seems that ndev->name is not fully
formed until register_netdev() is called and so when the thread is
created, the malformed name is used for the thread name.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2013-01-29 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 13:51 [PATCH] net: ks8851: convert to threaded IRQ Felipe Balbi
2013-01-29 3:31 ` David Miller
2013-01-29 4:33 ` Joe Perches
2013-01-29 7:16 ` Felipe Balbi
2013-01-29 18:32 ` David Miller
2013-01-29 18:53 ` Stephen Boyd [this message]
2013-01-29 19:02 ` Felipe Balbi
2013-01-29 19:21 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51081A94.1090202@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=balbi@ti.com \
--cc=davem@davemloft.net \
--cc=mjr@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).