From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] net: ks8851: convert to threaded IRQ Date: Tue, 29 Jan 2013 10:53:08 -0800 Message-ID: <51081A94.1090202@codeaurora.org> References: <20130128.223157.1855971357181002973.davem@davemloft.net> <1359443790-8562-1-git-send-email-balbi@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, mjr@cs.wisc.edu, netdev@vger.kernel.org To: Felipe Balbi Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:60354 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752480Ab3A2SxJ (ORCPT ); Tue, 29 Jan 2013 13:53:09 -0500 In-Reply-To: <1359443790-8562-1-git-send-email-balbi@ti.com> Sender: netdev-owner@vger.kernel.org List-ID: On 01/28/13 23:16, Felipe Balbi wrote: > just as it should have been. It also helps > removing the, now unnecessary, workqueue. Tested-by: Stephen Boyd > Signed-off-by: Felipe Balbi > --- > @@ -1505,8 +1485,9 @@ static int ks8851_probe(struct spi_device *spi) > ks8851_read_selftest(ks); > ks8851_init_mac(ks); > > - ret = request_irq(spi->irq, ks8851_irq, IRQF_TRIGGER_LOW, > - ndev->name, ks); > + ret = request_threaded_irq(spi->irq, NULL, ks8851_irq, > + IRQF_TRIGGER_LOW | IRQF_ONESHOT, > + ndev->name, ks); I did notice one thing here. The name of the thread is irq/378-eth%d (where 378 is the irq number). It seems that ndev->name is not fully formed until register_netdev() is called and so when the thread is created, the malformed name is used for the thread name. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation