From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vlad Yasevich <vyasevic@redhat.com>
Subject: Re: [Bridge] [PATCH v7 net-next 01/12] bridge: Add vlan filtering
 infrastructure
Date: Thu, 31 Jan 2013 15:34:57 -0500
Message-ID: <510AD571.6060309@redhat.com>
References: <1359601979-14942-1-git-send-email-vyasevic@redhat.com> <1359601979-14942-2-git-send-email-vyasevic@redhat.com> <CAHXqBFL88O=cSse5AdhoKMMMrvgvn7oYAhMxt0rw9ffv49Z7hw@mail.gmail.com> <510AD51D.6080506@superduper.net>
Reply-To: vyasevic@redhat.com
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-2;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: =?ISO-8859-2?Q?Micha=B3_Miros=B3aw?= <mirqus@gmail.com>,
	netdev@vger.kernel.org, shemminger@vyatta.com,
	bridge@lists.linux-foundation.org, davem@davemloft.net,
	shmulik.ladkani@gmail.com
To: Simon Barber <simon@superduper.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:32926 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753360Ab3AaUfK (ORCPT <rfc822;netdev@vger.kernel.org>);
	Thu, 31 Jan 2013 15:35:10 -0500
In-Reply-To: <510AD51D.6080506@superduper.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 01/31/2013 03:33 PM, Simon Barber wrote:
> I wrote a similar patch a few years ago:
>
> https://lists.linux-foundation.org/pipermail/bridge/2006-September/00=
5046.html
>
>
> This patch also added the possibility to define a native vlan for eac=
h
> port and for the bridge port itself - is there any interest in this
> feature as well as the filtering?
>

See patch 5 and 6 and the series :)

-vlad

> Simon
>
>
> On 01/31/2013 11:57 AM, Micha=B3 Miros=B3aw wrote:
>> 2013/1/31 Vlad Yasevich <vyasevic@redhat.com>:
>>> Adds an optional infrustructure component to bridge that would allo=
w
>>> native vlan filtering in the bridge.  Each bridge port (as well
>>> as the bridge device) now get a VLAN bitmap.  Each bit in the bitma=
p
>>> is associated with a vlan id.  This way if the bit corresponding to
>>> the vid is set in the bitmap that the packet with vid is allowed to
>>> enter and exit the port.
>>>
>>> Write access the bitmap is protected by RTNL and read access
>>> protected by RCU.
>> [...]
>>> +static int __vlan_del(struct net_port_vlans *v, u16 vid)
>>> +{
>>> +       unsigned long first_bit;
>>> +       unsigned long last_bit;
>>> +
>>> +       if (!test_bit(vid, v->vlan_bitmap))
>>> +               return -EINVAL;
>>> +
>>> +       /* Check to see if any other vlans are in this table.  If t=
his
>>> +        * is the last vlan, delete the whole structure.  If this i=
s
>>> not the
>>> +        * last vlan, just clear the bit.
>>> +        */
>>> +       first_bit =3D find_first_bit(v->vlan_bitmap, BR_VLAN_BITMAP=
_LEN);
>>> +       last_bit =3D find_last_bit(v->vlan_bitmap, BR_VLAN_BITMAP_L=
EN);
>>> +
>>> +       if (v->port_idx && vid) {
>>> +               struct net_device *dev =3D vlans_to_port(v)->dev;
>>> +
>>> +               if (dev->features & NETIF_F_HW_VLAN_FILTER)
>>> +                       dev->netdev_ops->ndo_vlan_rx_kill_vid(dev, =
vid);
>>> +       }
>>> +
>>> +       clear_bit(vid, v->vlan_bitmap);
>>> +       if (first_bit =3D=3D last_bit) {
>>
>> if (bitmap_empty(v->vlan_bitmap, BR_VLAN_BITMAP_LEN))
>>
>>> +               if (v->port_idx) {
>>> +                       struct net_bridge_port *p =3D vlans_to_port=
(v);
>>> +                       rcu_assign_pointer(p->vlan_info, NULL);
>>> +               } else {
>>> +                       struct net_bridge *br =3D vlans_to_bridge(v=
);
>>> +                       rcu_assign_pointer(br->vlan_info, NULL);
>>> +               }
>>
>> You seem to use vlans_to_port/vlans_to_bridge only to get at
>> vlan_info. Maybe that could be abstracted to a single interface, or
>> even change v->parent to be a 'net_port_vlans **'?
>>
>> Best Regards,
>> Micha=B3 Miros=B3aw
>>