From: Daniel Borkmann <dborkman@redhat.com>
To: Phil Sutter <phil.sutter@viprinet.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Johann Baudy <johann.baudy@gnu-log.net>
Subject: Re: [PATCH v2] packet: fix leakage of tx_ring memory
Date: Fri, 01 Feb 2013 18:25:13 +0100 [thread overview]
Message-ID: <510BFA79.90705@redhat.com> (raw)
In-Reply-To: <1359739301-14044-1-git-send-email-phil.sutter@viprinet.com>
On 02/01/2013 06:21 PM, Phil Sutter wrote:
> When releasing a packet socket, the routine packet_set_ring() is reused
> to free rings instead of allocating them. But when calling it for the
> first time, it fills req->tp_block_nr with the value of rb->pg_vec_len
> which in the second invocation makes it bail out since req->tp_block_nr
> is greater zero but req->tp_block_size is zero.
>
> This patch solves the problem by passing a zeroed auto-variable to
> packet_set_ring() upon each invocation from packet_release().
>
> As far as I can tell, this issue exists even since 69e3c75 (net: TX_RING
> and packet mmap), i.e. the original inclusion of TX ring support into
> af_packet, but applies only to sockets with both RX and TX ring
> allocated, which is probably why this was unnoticed all the time.
>
> Signed-off-by: Phil Sutter <phil.sutter@viprinet.com>
> Cc: Johann Baudy <johann.baudy@gnu-log.net>
> Cc: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Daniel Borkmann <dborkman@redhat.com>
next prev parent reply other threads:[~2013-02-01 17:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 13:57 [PATCH] packet: fix leakage of tx_ring memory Phil Sutter
2013-02-01 16:05 ` Daniel Borkmann
2013-02-01 16:21 ` Phil Sutter
2013-02-01 16:48 ` Daniel Borkmann
2013-02-01 17:21 ` [PATCH v2] " Phil Sutter
2013-02-01 17:25 ` Daniel Borkmann [this message]
2013-02-03 21:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510BFA79.90705@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=johann.baudy@gnu-log.net \
--cc=netdev@vger.kernel.org \
--cc=phil.sutter@viprinet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).