From: "Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>
To: Frank Li <lznuaa@gmail.com>
Cc: Jim Baxter <jim_baxter@mentor.com>, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net: fec: fix miss init spinlock
Date: Wed, 06 Feb 2013 05:48:24 -0800 [thread overview]
Message-ID: <51125F28.4000409@intel.com> (raw)
In-Reply-To: <CAHrpEqTsUjWjxY3_C4kGL_S0pgpYawgBaSip3DEnZd3CY1hn0A@mail.gmail.com>
On 2/6/2013 1:50 AM, Frank Li wrote:
>
> It is not easy to fix. Need put tx to NAPI poll function.
> I will work on that after China New year holiday
Converting Tx to NAPI is the best solution, but you can put a temporary
fix in. Don't take a spin_lock() in fec_enet_tx(), rather take a
spin_lock_irqsave() since you're still in HARDIRQ context.
-PJ
next prev parent reply other threads:[~2013-02-06 13:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 8:56 [PATCH 1/1] net: fec: fix miss init spinlock Frank Li
2013-02-03 4:08 ` David Miller
2013-02-04 2:22 ` Frank Li
2013-02-04 5:24 ` David Miller
2013-02-04 6:31 ` Frank Li
2013-02-04 20:03 ` David Miller
2013-02-04 16:52 ` Jim Baxter
2013-02-05 7:05 ` Frank Li
2013-02-05 10:18 ` Jim Baxter
2013-02-06 9:50 ` Frank Li
2013-02-06 13:48 ` Waskiewicz Jr, Peter P [this message]
2013-02-07 1:42 ` Frank Li
2013-02-22 12:25 ` Jim Baxter
2013-02-22 21:17 ` Fabio Estevam
2013-02-23 0:46 ` Frank Li
2013-02-23 2:08 ` Fabio Estevam
2013-02-04 23:23 ` Dmitry Eremin-Solenikov
2013-02-05 2:40 ` Frank Li
2013-02-21 17:07 ` Jim Baxter
2013-02-21 17:28 ` Fabio Estevam
2013-02-21 17:59 ` Jim Baxter
2013-02-21 18:03 ` David Miller
2013-02-21 18:04 ` Fabio Estevam
2013-02-21 19:04 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51125F28.4000409@intel.com \
--to=peter.p.waskiewicz.jr@intel.com \
--cc=jim_baxter@mentor.com \
--cc=lznuaa@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).