From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Greear Subject: Re: [PATCH] net: mac80211/cfg.c: fix error using of sizeof() Date: Wed, 06 Feb 2013 09:59:46 -0800 Message-ID: <51129A12.6020101@candelatech.com> References: <1360167826-29265-1-git-send-email-dinggnu@gmail.com> (sfid-20130206_172354_765098_665D60D0) <1360168022.7910.22.camel@jlt4.sipsolutions.net> <511298E8.7090801@candelatech.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Cong Ding , "John W. Linville" , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Johannes Berg Return-path: In-Reply-To: <511298E8.7090801@candelatech.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 02/06/2013 09:54 AM, Ben Greear wrote: > On 02/06/2013 08:27 AM, Johannes Berg wrote: >> On Wed, 2013-02-06 at 17:23 +0100, Cong Ding wrote: >>> Using 'sizeof' on array given as function argument returns size of a pointer >>> rather than the size of array. >> >> Oops, yeah, Stephen Hemminger pointed this out a month or so ago and I >> forgot to change it, thanks. > > This needs to be back-ported for 3.7 stable? Perhaps the code below > corresponds (from copy_mesh_setup)? > > > /* mcast rate setting in Mesh Node */ > memcpy(sdata->vif.bss_conf.mcast_rate, setup->mcast_rate, > sizeof(setup->mcast_rate)); Nevermind..I think I'm wrong about that..the sizeof probably works fine here. Sorry for the noise. Ben > > Thanks, > Ben > -- Ben Greear Candela Technologies Inc http://www.candelatech.com