From: Hauke Mehrtens <hauke@hauke-m.de>
To: Michael Chan <mchan@broadcom.com>
Cc: davem@davemloft.net, mcarlson@broadcom.com, nsujir@broadcom.com,
netdev@vger.kernel.org, m@bues.ch
Subject: Re: [PATCH v3 3/3] tg3: add support for Ethernet core in bcm4785
Date: Thu, 07 Feb 2013 15:31:55 +0100 [thread overview]
Message-ID: <5113BADB.6090204@hauke-m.de> (raw)
In-Reply-To: <1360202768.796.6.camel@LTIRV-MCHAN1.corp.ad.broadcom.com>
On 02/07/2013 03:06 AM, Michael Chan wrote:
> On Wed, 2013-02-06 at 23:46 +0100, Hauke Mehrtens wrote:
>> @@ -16165,7 +16256,8 @@ static int tg3_test_dma(struct tg3 *tp)
>> if (tg3_flag(tp, 40BIT_DMA_BUG) &&
>> GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704)
>> tp->dma_rwctrl |= 0x8000;
>> - else if (ccval == 0x6 || ccval == 0x7)
>> + else if ((ccval == 0x6 || ccval == 0x7) ||
>> + tg3_flag(tp, ONE_DMA_AT_ONCE))
>
> This code path is only for the older 5703 and 5704. So it won't be
> applicable for this ethernet core, right?
I just had a look into the original source provided with my Router for
this chip and you are right, this code should be placed after the checks
for specific chips. I will resend this patch series. This
ONE_DMA_AT_ONCE does not affect my Ethernet core, because this should
only be done for rev < 2 bcm4785 chips and mine is rev 2.
>> tp->dma_rwctrl |= DMA_RWCTRL_ONE_DMA;
>>
>> if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5703)
Hauke
prev parent reply other threads:[~2013-02-07 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 22:46 [PATCH v3 0/3] tg3: add support for Ethernet core in BCM4785 Hauke Mehrtens
2013-02-06 22:46 ` [PATCH v3 1/3] ssb: get mac address from sprom struct for gige driver Hauke Mehrtens
2013-02-06 22:46 ` [PATCH v3 2/3] tg3: make it possible to provide phy_id in ioctl Hauke Mehrtens
2013-02-06 22:46 ` [PATCH v3 3/3] tg3: add support for Ethernet core in bcm4785 Hauke Mehrtens
2013-02-07 2:06 ` Michael Chan
2013-02-07 14:31 ` Hauke Mehrtens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5113BADB.6090204@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=davem@davemloft.net \
--cc=m@bues.ch \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nsujir@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox