From: Alexander Duyck <alexander.h.duyck@intel.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, jeffrey.t.kirsher@intel.com,
netdev@vger.kernel.org, gospo@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 05/10] igb: Update igb to use a path similar to ixgbe to determine when to stop Tx
Date: Fri, 08 Feb 2013 12:19:29 -0800 [thread overview]
Message-ID: <51155DD1.8030500@intel.com> (raw)
In-Reply-To: <20130208.141854.2122874496462368419.davem@davemloft.net>
On 2/8/2013 11:18 AM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> Date: Fri, 08 Feb 2013 09:11:10 -0800
>
>> For igb the IGB_MAX_DATA_PER_TXD is 32K as well. So if I am not
>> mistaken we should be fine. The only time we risk exceeding that is
>> if we have 64K page size. It sounds like we may need to work in the
>> ixgbe driver though since I believe the limit for it is only 16K per
>> descriptor.
>>
>> I will also submit an update for this patch that replaces PAGE_SIZE
>> with NETDEV_FRAG_PAGE_MAX_SIZE in order to keep the two in sync.
> I therefore expect a respin of this series from Jeff once the
> update of this patch is resolved.
>
> Thanks.
I will work with Jeff to get that resolved. Also I will be submitting
one patch directly it looks like since NETDEV_FRAG_PAGE_MAX_SIZE turns
out to be defined in skbuff.c so I will need to pull it into skbuff.h
most likely.
Thanks,
Alex
next prev parent reply other threads:[~2013-02-08 20:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 10:39 [net-next 00/10][pull request] Intel Wired LAN Driver Updates Jeff Kirsher
2013-02-08 10:39 ` [net-next 01/10] igb: Support using build_skb in the case that jumbo frames are disabled Jeff Kirsher
2013-02-08 10:39 ` [net-next 02/10] igb: Fix for improper exit in igb_get_i2c_client Jeff Kirsher
2013-02-08 10:39 ` [net-next 03/10] igb: Fix for improper allocation flag " Jeff Kirsher
2013-02-08 10:39 ` [net-next 04/10] igb: Fix for sparse warning " Jeff Kirsher
2013-02-11 17:05 ` Ben Hutchings
2013-02-11 17:27 ` Wyborny, Carolyn
2013-02-12 17:12 ` Wyborny, Carolyn
2013-02-12 17:17 ` Wyborny, Carolyn
2013-02-08 10:39 ` [net-next 05/10] igb: Update igb to use a path similar to ixgbe to determine when to stop Tx Jeff Kirsher
2013-02-08 12:26 ` Eric Dumazet
2013-02-08 17:11 ` Alexander Duyck
2013-02-08 19:18 ` David Miller
2013-02-08 20:19 ` Alexander Duyck [this message]
2013-02-08 10:39 ` [net-next 06/10] igb: Initialize PHY function pointers Jeff Kirsher
2013-02-08 10:39 ` [net-next 07/10] igb: Initialize NVM " Jeff Kirsher
2013-02-08 10:39 ` [net-next 08/10] igb: Intialize MAC " Jeff Kirsher
2013-02-08 10:39 ` [net-next 09/10] igb: Refractoring function pointers in igb_get_invariants function Jeff Kirsher
2013-02-08 10:39 ` [net-next 10/10] ixgbe: refactor initialization of feature flags Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51155DD1.8030500@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).