* [PATCH v2] ipv6: don't accept multicast traffic with scop 0
@ 2013-02-10 15:35 Hannes Frederic Sowa
2013-02-10 18:09 ` YOSHIFUJI Hideaki
2013-02-11 19:01 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Hannes Frederic Sowa @ 2013-02-10 15:35 UTC (permalink / raw)
To: netdev
v2:
a) moved before multicast source address check
b) changed comment to netdev style
Cc: Erik Hugne <erik.hugne@ericsson.com>
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/ip6_input.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
index 4ac5bf3..521d9fd 100644
--- a/net/ipv6/ip6_input.c
+++ b/net/ipv6/ip6_input.c
@@ -118,6 +118,15 @@ int ipv6_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt
ipv6_addr_loopback(&hdr->daddr))
goto err;
+ /* RFC4291 2.7
+ * Nodes must not originate a packet to a multicast address whose scop
+ * field contains the reserved value 0; if such a packet is received, it
+ * must be silently dropped.
+ */
+ if (ipv6_addr_is_multicast(&hdr->daddr) &&
+ IPV6_ADDR_MC_SCOPE(&hdr->daddr) == 0)
+ goto err;
+
/*
* RFC4291 2.7
* Multicast addresses must not be used as source addresses in IPv6
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ipv6: don't accept multicast traffic with scop 0
2013-02-10 15:35 [PATCH v2] ipv6: don't accept multicast traffic with scop 0 Hannes Frederic Sowa
@ 2013-02-10 18:09 ` YOSHIFUJI Hideaki
2013-02-11 19:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: YOSHIFUJI Hideaki @ 2013-02-10 18:09 UTC (permalink / raw)
To: netdev, David Miller; +Cc: YOSHIFUJI Hideaki
Hannes Frederic Sowa wrote:
> v2:
> a) moved before multicast source address check
> b) changed comment to netdev style
>
> Cc: Erik Hugne <erik.hugne@ericsson.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
> net/ipv6/ip6_input.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
> index 4ac5bf3..521d9fd 100644
> --- a/net/ipv6/ip6_input.c
> +++ b/net/ipv6/ip6_input.c
> @@ -118,6 +118,15 @@ int ipv6_rcv(struct sk_buff *skb, struct net_device *dev, struct packet_type *pt
> ipv6_addr_loopback(&hdr->daddr))
> goto err;
>
> + /* RFC4291 2.7
> + * Nodes must not originate a packet to a multicast address whose scop
> + * field contains the reserved value 0; if such a packet is received, it
> + * must be silently dropped.
> + */
> + if (ipv6_addr_is_multicast(&hdr->daddr) &&
> + IPV6_ADDR_MC_SCOPE(&hdr->daddr) == 0)
> + goto err;
> +
> /*
> * RFC4291 2.7
> * Multicast addresses must not be used as source addresses in IPv6
>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
--yoshfuji
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] ipv6: don't accept multicast traffic with scop 0
2013-02-10 15:35 [PATCH v2] ipv6: don't accept multicast traffic with scop 0 Hannes Frederic Sowa
2013-02-10 18:09 ` YOSHIFUJI Hideaki
@ 2013-02-11 19:01 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2013-02-11 19:01 UTC (permalink / raw)
To: hannes; +Cc: netdev
From: Hannes Frederic Sowa <hannes@stressinduktion.org>
Date: Sun, 10 Feb 2013 16:35:22 +0100
> v2:
> a) moved before multicast source address check
> b) changed comment to netdev style
>
> Cc: Erik Hugne <erik.hugne@ericsson.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-02-11 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-10 15:35 [PATCH v2] ipv6: don't accept multicast traffic with scop 0 Hannes Frederic Sowa
2013-02-10 18:09 ` YOSHIFUJI Hideaki
2013-02-11 19:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).