From: Ben Dooks <ben.dooks@codethink.co.uk>
To: Rob Herring <robherring2@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] net: calexdaxgmac: fix printing of hardware version
Date: Mon, 11 Feb 2013 10:59:53 +0000 [thread overview]
Message-ID: <5118CF29.3040205@codethink.co.uk> (raw)
In-Reply-To: <5118208C.7010109@gmail.com>
On 10/02/13 22:34, Rob Herring wrote:
> On 02/10/2013 09:38 AM, Ben Dooks wrote:
>> The current driver attempts to print netdev_info() before registering the
>> network device and allowing the name to be set. Change this print to be
>> after the network deviec has been registered, and thus has been allocated
>
> You missed the typo pointed out on the first version sent to lakml.
Oops, sorry.
>> a network device name.
>>
>> Fix the following issue:
>>
>> calxedaxgmac fff50000.ethernet (unregistered net_device): h/w version is 0x1012
>>
>> Signed-off-by: Ben Dooks<ben.dooks@codethink.co.uk>
>
> Otherwise,
>
> Acked-by: Rob Herring<rob.herring@calxeda.com>
Thanks.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2013-02-11 10:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-10 15:38 calexda/xgmac bug fixes Ben Dooks
2013-02-10 15:38 ` [PATCH 1/2] net: calexdaxgmac: fix printing of hardware version Ben Dooks
2013-02-10 22:34 ` Rob Herring
2013-02-11 10:59 ` Ben Dooks [this message]
2013-02-10 15:38 ` [PATCH 2/2] net: calexdaxgmac: fixup endian issues after __raw IO function change Ben Dooks
2013-02-10 22:32 ` Rob Herring
2013-02-11 18:17 ` Ben Hutchings
2013-02-11 18:27 ` Ben Dooks
2013-02-12 9:19 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5118CF29.3040205@codethink.co.uk \
--to=ben.dooks@codethink.co.uk \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=robherring2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).