From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH 1/1] VSOCK: Introduce VM Sockets Date: Tue, 19 Feb 2013 09:45:38 +0100 Message-ID: <51233BB2.3080401@redhat.com> References: <1360196636-9357-1-git-send-email-acking@vmware.com> <1360196636-9357-2-git-send-email-acking@vmware.com> <511CC511.7080902@redhat.com> <1398469748.2079082.1361207251021.JavaMail.root@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: pv-drivers@vmware.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, gregkh@linuxfoundation.org, davem@davemloft.net To: Andy King Return-path: In-Reply-To: <1398469748.2079082.1361207251021.JavaMail.root@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 02/18/13 18:07, Andy King wrote: > Hi Gerd, > >>> + written = transport->stream_enqueue( >>> + vsk, msg->msg_iov, >>> + len - total_written); >> >> Hmm, shouldn't we pass total_written to stream_enqueue here? >> >> In case a blocking send(big-buffer) call gets splitted into multiple >> stream_enqueue calls the second (and further) stream_enqueue calls need >> to know at which msg offset they should continue sending the data, no? > > On the client side, the iov tracks it internally; see memcpy_fromiovec(). Ah, memcpy_fromiovec patches the iovec to keep track of the offset. Wasn't aware it does this. Yes, we don't need to pass the offset then. cheers, Gerd