From: Alexander Duyck <alexander.h.duyck@intel.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, fengguang.wu@intel.com,
dan.carpenter@oracle.com, jeffrey.t.kirsher@intel.com
Subject: Re: [PATCH] net: Fix locking bug in netif_set_xps_queue
Date: Fri, 22 Feb 2013 13:21:09 -0800 [thread overview]
Message-ID: <5127E145.2070008@intel.com> (raw)
In-Reply-To: <20130222.151442.333174353561165623.davem@davemloft.net>
On 02/22/2013 12:14 PM, David Miller wrote:
> From: Alexander Duyck <alexander.h.duyck@intel.com>
> Date: Fri, 22 Feb 2013 08:38:44 -0800
>
>> Smatch found a locking bug in netif_set_xps_queue in which we were not
>> releasing the lock in the case of an allocation failure.
>>
>> This change corrects that so that we release the xps_map_mutex before
>> returning -ENOMEM in the case of an allocation failure.
>>
>> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Applied and queue up for -stable, thanks Alex.
No patch is needed for -stable. This was something I had introduced
into net-next when I moved the XPS logic into its own function.
Thanks,
Alex
next prev parent reply other threads:[~2013-02-22 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 16:38 [PATCH] net: Fix locking bug in netif_set_xps_queue Alexander Duyck
2013-02-22 20:14 ` David Miller
2013-02-22 21:21 ` Alexander Duyck [this message]
2013-02-22 21:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5127E145.2070008@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=fengguang.wu@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox