From: Jiri Slaby <jslaby@suse.cz>
To: Chen Gang <gang.chen@asianux.com>, Jiri Kosina <jkosina@suse.cz>,
isdn@linux-pingi.de
Cc: Greg KH <gregkh@linuxfoundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
netdev <netdev@vger.kernel.org>
Subject: Re: [Suggestion] drivers/isdn: about the loop after call isdn_tty_send_msg
Date: Wed, 27 Feb 2013 11:00:44 +0100 [thread overview]
Message-ID: <512DD94C.2020008@suse.cz> (raw)
In-Reply-To: <512DD2B3.2070404@asianux.com>
On 02/27/2013 10:32 AM, Chen Gang wrote:
> Hello Maintainers:
>
> do we need break out of the loop after call isdn_tty_send_msg ?
> p is not increased after finish calling isdn_tty_send_msg.
> and then will loop back to process the p again.
>
> do we intend to scan again the string which appended "+M..." ?
Nope, we should break the for loop because isdn_tty_send_msg is intended
to eat the rest of the string. Evidently nobody tested this path yet.
> we also assume "+M..." is a NUL terminated string, is it OK ? (it seems ok)
Yes, p should be NUL-terminated.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2013-02-27 10:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-27 9:32 [Suggestion] drivers/isdn: about the loop after call isdn_tty_send_msg Chen Gang
2013-02-27 10:00 ` Jiri Slaby [this message]
2013-02-27 10:08 ` Chen Gang
2013-02-28 2:57 ` [PATCH] drivers/isdn: break out of " Chen Gang
2013-02-28 9:54 ` Jiri Slaby
2013-03-15 2:02 ` Chen Gang
2013-03-20 5:03 ` Chen Gang
2013-03-25 3:27 ` Chen Gang
2013-03-29 1:56 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=512DD94C.2020008@suse.cz \
--to=jslaby@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gang.chen@asianux.com \
--cc=gregkh@linuxfoundation.org \
--cc=isdn@linux-pingi.de \
--cc=jkosina@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).