public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Marek Behún" <marek.behun@nic.cz>
Cc: Michal Smulski <msmulski2@gmail.com>,
	f.fainelli@gmail.com, olteanv@gmail.com, netdev@vger.kernel.org,
	Michal Smulski <michal.smulski@ooma.com>
Subject: Re: [PATCH net-next v2] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x
Date: Mon, 29 May 2023 17:11:28 +0200	[thread overview]
Message-ID: <512cef84-b7f0-4532-86a3-6972d05ca25d@lunn.ch> (raw)
In-Reply-To: <20230528092522.47enrnrslgflovmx@kandell>

On Sun, May 28, 2023 at 11:25:22AM +0200, Marek Behún wrote:
> You need also to implement serdes_pcs_get_state for USXGMII.
> 
> Preferably by adding USXGMII relevant register constants into
> include/uapi/linux/mii.h, and using them to parse state register.

And if a standard is being followed here, please try to make the code
as helpers, so other USXGMII implementations can use them.

Thanks

	Andrew

  reply	other threads:[~2023-05-29 15:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-27 17:20 [PATCH net-next v2] net: dsa: mv88e6xxx: implement USXGMII mode for mv88e6393x Michal Smulski
2023-05-28  9:25 ` Marek Behún
2023-05-29 15:11   ` Andrew Lunn [this message]
2023-05-29 17:23     ` Michal Smulski
2023-05-30 13:54       ` Marek Behún
2023-05-31  5:54         ` Michal Smulski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=512cef84-b7f0-4532-86a3-6972d05ca25d@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=michal.smulski@ooma.com \
    --cc=msmulski2@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox