From: Jiri Slaby <jslaby@suse.cz>
To: channing <chao.bi@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, ML netdev <netdev@vger.kernel.org>,
vincentx.pillet@intel.com
Subject: Re: [PATCH] n_gsm: Add Mutex to avoid race when net destroy
Date: Fri, 01 Mar 2013 10:10:17 +0100 [thread overview]
Message-ID: <51307079.2050905@suse.cz> (raw)
In-Reply-To: <1362127915.31563.18.camel@bichao>
On 03/01/2013 09:51 AM, channing wrote:
>> It should stop the queue and schedule a workqueue to lock the mutex,
>> unregister the hetdev and reset dlci->net. (Or maybe just call
>> muxnet_put with the lock held.)
>
> Thanks, Jiri, you're right, I didn't notice that in validation because
> DEBUG_ATOMIC_SLEEP is not enabled in my platform :( Now I'm trying to
> work out the workqueue solution, when it finished I'll re-submit for
> review. What do you mean by "call muxnet_put with lock held"? do you
> mean to use spin lock instead of mutex?
No, I mean, in the newly added scheduled work, to lock the mutex and
simply call muxnet_put. That should fix it, right?
--
js
suse labs
next prev parent reply other threads:[~2013-03-01 9:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1362029486.31563.5.camel@bichao>
2013-02-28 9:53 ` [PATCH] n_gsm: Add Mutex to avoid race when net destroy Jiri Slaby
2013-03-01 8:51 ` channing
2013-03-01 9:10 ` Jiri Slaby [this message]
2013-03-01 11:04 ` Bi, Chao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51307079.2050905@suse.cz \
--to=jslaby@suse.cz \
--cc=chao.bi@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vincentx.pillet@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).