* tg3: regression of netdev stats
@ 2013-03-01 13:21 OGAWA Hirofumi
2013-03-01 15:47 ` Michael Chan
0 siblings, 1 reply; 6+ messages in thread
From: OGAWA Hirofumi @ 2013-03-01 13:21 UTC (permalink / raw)
To: nsujir, mchan, davem; +Cc: netdev
Hi,
f4a46d1f46a8fece34edd2023e054072b02e110d (tg3: Prevent spurious tx
timeout by setting carrier off before tx disable.) seems to add the bug.
On 3.8.1 (I didn't use 3.7.x series), "ifconfig" commands doesn't show
any stats, i.e. all stats are zero. And bisect points the above commit.
In fact, reverting the above patch fixes the regression of netdev stats.
This patch looks like strange, and I'm not sure what this want to do.
Any ideas?
Well, anyway, this is bug report.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tg3: regression of netdev stats
2013-03-01 13:21 tg3: regression of netdev stats OGAWA Hirofumi
@ 2013-03-01 15:47 ` Michael Chan
2013-03-02 2:30 ` Nithin Nayak Sujir
2013-03-02 6:10 ` OGAWA Hirofumi
0 siblings, 2 replies; 6+ messages in thread
From: Michael Chan @ 2013-03-01 15:47 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: nsujir, davem, netdev
On Fri, 2013-03-01 at 22:21 +0900, OGAWA Hirofumi wrote:
> Hi,
>
> f4a46d1f46a8fece34edd2023e054072b02e110d (tg3: Prevent spurious tx
> timeout by setting carrier off before tx disable.) seems to add the bug.
>
> On 3.8.1 (I didn't use 3.7.x series), "ifconfig" commands doesn't show
> any stats, i.e. all stats are zero.
No stats on an active device transmitting and receiving packets? I
don't seem to see the same problem, but we'll look into this further.
Thanks.
> And bisect points the above commit.
> In fact, reverting the above patch fixes the regression of netdev stats.
>
> This patch looks like strange, and I'm not sure what this want to do.
> Any ideas?
Every time we reset the device (ethtool, MTU change, etc), we need to
turn off all the tx queues before resetting. As soon as we turn off
these queues, if we don't turn off carrier, a tx timeout may be
triggered if it's been more than 5 seconds since the last transmit on
any of the tx queues. These tx timeouts cause unnecessary concern to
the user.
>
> Well, anyway, this is bug report.
>
> Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tg3: regression of netdev stats
2013-03-01 15:47 ` Michael Chan
@ 2013-03-02 2:30 ` Nithin Nayak Sujir
2013-03-02 6:10 ` OGAWA Hirofumi
1 sibling, 0 replies; 6+ messages in thread
From: Nithin Nayak Sujir @ 2013-03-02 2:30 UTC (permalink / raw)
To: Michael Chan; +Cc: OGAWA Hirofumi, davem, netdev
On 3/1/2013 7:47 AM, Michael Chan wrote:
> On Fri, 2013-03-01 at 22:21 +0900, OGAWA Hirofumi wrote:
>> Hi,
>>
>> f4a46d1f46a8fece34edd2023e054072b02e110d (tg3: Prevent spurious tx
>> timeout by setting carrier off before tx disable.) seems to add the bug.
>>
>> On 3.8.1 (I didn't use 3.7.x series), "ifconfig" commands doesn't show
>> any stats, i.e. all stats are zero.
>
> No stats on an active device transmitting and receiving packets? I
> don't seem to see the same problem, but we'll look into this further.
> Thanks.
>
Hi Hirofumi,
I too am not able to see zero stats with 3.8.1. I ran traffic and stats
go up as expected.
Are you certain that the interface was up? Did you run ifconfig with
traffic running on the interface?
Thanks,
Nithin.
>> And bisect points the above commit.
>> In fact, reverting the above patch fixes the regression of netdev stats.
>>
>> This patch looks like strange, and I'm not sure what this want to do.
>> Any ideas?
>
> Every time we reset the device (ethtool, MTU change, etc), we need to
> turn off all the tx queues before resetting. As soon as we turn off
> these queues, if we don't turn off carrier, a tx timeout may be
> triggered if it's been more than 5 seconds since the last transmit on
> any of the tx queues. These tx timeouts cause unnecessary concern to
> the user.
>
>>
>> Well, anyway, this is bug report.
>>
>> Thanks.
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tg3: regression of netdev stats
2013-03-01 15:47 ` Michael Chan
2013-03-02 2:30 ` Nithin Nayak Sujir
@ 2013-03-02 6:10 ` OGAWA Hirofumi
2013-03-02 6:20 ` OGAWA Hirofumi
1 sibling, 1 reply; 6+ messages in thread
From: OGAWA Hirofumi @ 2013-03-02 6:10 UTC (permalink / raw)
To: Michael Chan; +Cc: nsujir, davem, netdev
"Michael Chan" <mchan@broadcom.com> writes:
> On Fri, 2013-03-01 at 22:21 +0900, OGAWA Hirofumi wrote:
>> Hi,
>>
>> f4a46d1f46a8fece34edd2023e054072b02e110d (tg3: Prevent spurious tx
>> timeout by setting carrier off before tx disable.) seems to add the bug.
>>
>> On 3.8.1 (I didn't use 3.7.x series), "ifconfig" commands doesn't show
>> any stats, i.e. all stats are zero.
>
> No stats on an active device transmitting and receiving packets? I
> don't seem to see the same problem, but we'll look into this further.
> Thanks.
Yes, /proc/net/dev didn't show any packet traffic stats (always
zero). But, e.g. ping/nfs itself works fine.
BTW, chip is
02:00.0 Ethernet controller [0200]: Broadcom Corporation NetLink BCM57788 Gigabit Ethernet PCIe [14e4:1691] (rev 01)
tg3 0000:02:00.0 eth0: Tigon3 [partno(BCM57788) rev 57780001] (PCI Express) MAC address d4:be:d9:a6:a3:3b
tg3 0000:02:00.0 eth0: attached PHY driver [Broadcom BCM57780] (mii_bus:phy_addr=200:01)
>> And bisect points the above commit.
>> In fact, reverting the above patch fixes the regression of netdev stats.
>>
>> This patch looks like strange, and I'm not sure what this want to do.
>> Any ideas?
>
> Every time we reset the device (ethtool, MTU change, etc), we need to
> turn off all the tx queues before resetting. As soon as we turn off
> these queues, if we don't turn off carrier, a tx timeout may be
> triggered if it's been more than 5 seconds since the last transmit on
> any of the tx queues. These tx timeouts cause unnecessary concern to
> the user.
Hmm... I'm not reading codes almost, so this might be wrong
though. tg3_phy_reset() set off if ->link_up, so this seems to be not
saving original state, and I'm not sure what want to do with ->link_up.
I felt the following pesudo code might be work and simple...
ok = netif_carrier_ok()
netif_carrier_off()
[reconfigure...]
if (ok)
netif_carrier_on()
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: tg3: regression of netdev stats
2013-03-02 6:10 ` OGAWA Hirofumi
@ 2013-03-02 6:20 ` OGAWA Hirofumi
2013-03-02 18:56 ` Nithin Nayak Sujir
0 siblings, 1 reply; 6+ messages in thread
From: OGAWA Hirofumi @ 2013-03-02 6:20 UTC (permalink / raw)
To: Michael Chan; +Cc: nsujir, davem, netdev
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
> "Michael Chan" <mchan@broadcom.com> writes:
>
>> On Fri, 2013-03-01 at 22:21 +0900, OGAWA Hirofumi wrote:
>>> Hi,
>>>
>>> f4a46d1f46a8fece34edd2023e054072b02e110d (tg3: Prevent spurious tx
>>> timeout by setting carrier off before tx disable.) seems to add the bug.
>>>
>>> On 3.8.1 (I didn't use 3.7.x series), "ifconfig" commands doesn't show
>>> any stats, i.e. all stats are zero.
>>
>> No stats on an active device transmitting and receiving packets? I
>> don't seem to see the same problem, but we'll look into this further.
>> Thanks.
>
> Yes, /proc/net/dev didn't show any packet traffic stats (always
> zero). But, e.g. ping/nfs itself works fine.
>
> BTW, chip is
>
> 02:00.0 Ethernet controller [0200]: Broadcom Corporation NetLink BCM57788 Gigabit Ethernet PCIe [14e4:1691] (rev 01)
>
> tg3 0000:02:00.0 eth0: Tigon3 [partno(BCM57788) rev 57780001] (PCI Express) MAC address d4:be:d9:a6:a3:3b
> tg3 0000:02:00.0 eth0: attached PHY driver [Broadcom BCM57780] (mii_bus:phy_addr=200:01)
With some read, this chip seems to be using PHYLIB, and PHYLIB modify
carrier state, so ->link_up confuses with it?
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: tg3: regression of netdev stats
2013-03-02 6:20 ` OGAWA Hirofumi
@ 2013-03-02 18:56 ` Nithin Nayak Sujir
0 siblings, 0 replies; 6+ messages in thread
From: Nithin Nayak Sujir @ 2013-03-02 18:56 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: Michael Chan, davem, netdev
On 3/1/2013 10:20 PM, OGAWA Hirofumi wrote:
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> writes:
>
>> zero). But, e.g. ping/nfs itself works fine.
>>
>> BTW, chip is
>>
>> 02:00.0 Ethernet controller [0200]: Broadcom Corporation NetLink BCM57788 Gigabit Ethernet PCIe [14e4:1691] (rev 01)
>>
>> tg3 0000:02:00.0 eth0: Tigon3 [partno(BCM57788) rev 57780001] (PCI Express) MAC address d4:be:d9:a6:a3:3b
>> tg3 0000:02:00.0 eth0: attached PHY driver [Broadcom BCM57780] (mii_bus:phy_addr=200:01)
>
> With some read, this chip seems to be using PHYLIB, and PHYLIB modify
> carrier state, so ->link_up confuses with it?
>
Yes, this may be relevant. I'll investigate further with this device.
> Thanks.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-03-02 18:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-01 13:21 tg3: regression of netdev stats OGAWA Hirofumi
2013-03-01 15:47 ` Michael Chan
2013-03-02 2:30 ` Nithin Nayak Sujir
2013-03-02 6:10 ` OGAWA Hirofumi
2013-03-02 6:20 ` OGAWA Hirofumi
2013-03-02 18:56 ` Nithin Nayak Sujir
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).