* Re: NET: FEC: dynamtic check DMA desc buff type
@ 2013-03-04 3:32 Greg Ungerer
2013-03-04 4:35 ` Frank Li
0 siblings, 1 reply; 3+ messages in thread
From: Greg Ungerer @ 2013-03-04 3:32 UTC (permalink / raw)
To: Frank Li; +Cc: Sascha Hauer, netdev, lkml
Hi Frank,
Commit ff43da86c69d76a726ffe7d1666148960dc1d108 ("NET: FEC: dynamtic
check DMA desc buff type") breaks building of the fec ethernet driver
for non CONFIG_ARCH_MXC targets.
For example building for ColdFire devices with FEC hardware now
fails like this
drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_nextdesc’:
drivers/net/ethernet/freescale/fec.c:215:18: error: invalid use of undefined type ‘struct bufdesc_ex’
drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_prevdesc’:
drivers/net/ethernet/freescale/fec.c:224:18: error: invalid use of undefined type ‘struct bufdesc_ex’
drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_start_xmit’:
drivers/net/ethernet/freescale/fec.c:286:37: error: arithmetic on pointer to an incomplete type
drivers/net/ethernet/freescale/fec.c:287:13: error: arithmetic on pointer to an incomplete type
drivers/net/ethernet/freescale/fec.c:324:7: error: dereferencing pointer to incomplete type
etc....
These where generated on 3.9-rc1.
Can you please fix?
Regards
Greg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: NET: FEC: dynamtic check DMA desc buff type
2013-03-04 3:32 NET: FEC: dynamtic check DMA desc buff type Greg Ungerer
@ 2013-03-04 4:35 ` Frank Li
2013-03-04 5:06 ` Greg Ungerer
0 siblings, 1 reply; 3+ messages in thread
From: Frank Li @ 2013-03-04 4:35 UTC (permalink / raw)
To: Greg Ungerer; +Cc: Frank Li, Sascha Hauer, netdev, lkml
2013/3/4 Greg Ungerer <gerg@uclinux.org>:
>
> Hi Frank,
>
> Commit ff43da86c69d76a726ffe7d1666148960dc1d108 ("NET: FEC: dynamtic
> check DMA desc buff type") breaks building of the fec ethernet driver
> for non CONFIG_ARCH_MXC targets.
>
> For example building for ColdFire devices with FEC hardware now
> fails like this
>
> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_nextdesc’:
> drivers/net/ethernet/freescale/fec.c:215:18: error: invalid use of undefined
> type ‘struct bufdesc_ex’
> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_prevdesc’:
> drivers/net/ethernet/freescale/fec.c:224:18: error: invalid use of undefined
> type ‘struct bufdesc_ex’
> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_start_xmit’:
> drivers/net/ethernet/freescale/fec.c:286:37: error: arithmetic on pointer to
> an incomplete type
> drivers/net/ethernet/freescale/fec.c:287:13: error: arithmetic on pointer to
> an incomplete type
> drivers/net/ethernet/freescale/fec.c:324:7: error: dereferencing pointer to
> incomplete type
> etc....
>
> These where generated on 3.9-rc1.
>
> Can you please fix?
I can fix it.
I have not build environment to test.
Can you help me to test it?
>
> Regards
> Greg
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: NET: FEC: dynamtic check DMA desc buff type
2013-03-04 4:35 ` Frank Li
@ 2013-03-04 5:06 ` Greg Ungerer
0 siblings, 0 replies; 3+ messages in thread
From: Greg Ungerer @ 2013-03-04 5:06 UTC (permalink / raw)
To: Frank Li; +Cc: Frank Li, Sascha Hauer, netdev, lkml
Hi Frank,
On 04/03/13 14:35, Frank Li wrote:
> 2013/3/4 Greg Ungerer <gerg@uclinux.org>:
>> Commit ff43da86c69d76a726ffe7d1666148960dc1d108 ("NET: FEC: dynamtic
>> check DMA desc buff type") breaks building of the fec ethernet driver
>> for non CONFIG_ARCH_MXC targets.
>>
>> For example building for ColdFire devices with FEC hardware now
>> fails like this
>>
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_nextdesc’:
>> drivers/net/ethernet/freescale/fec.c:215:18: error: invalid use of undefined
>> type ‘struct bufdesc_ex’
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_get_prevdesc’:
>> drivers/net/ethernet/freescale/fec.c:224:18: error: invalid use of undefined
>> type ‘struct bufdesc_ex’
>> drivers/net/ethernet/freescale/fec.c: In function ‘fec_enet_start_xmit’:
>> drivers/net/ethernet/freescale/fec.c:286:37: error: arithmetic on pointer to
>> an incomplete type
>> drivers/net/ethernet/freescale/fec.c:287:13: error: arithmetic on pointer to
>> an incomplete type
>> drivers/net/ethernet/freescale/fec.c:324:7: error: dereferencing pointer to
>> incomplete type
>> etc....
>>
>> These where generated on 3.9-rc1.
>>
>> Can you please fix?
>
> I can fix it.
> I have not build environment to test.
> Can you help me to test it?
Oh yes, I can test any fixes.
If you had a m68k-linux compiler you can build with the
arch/m68k/configs/m5208evb_defconfig which shows the problem.
Regards
Greg
>> --
>> To unsubscribe from this list: send the line "unsubscribe netdev" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-04 5:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-04 3:32 NET: FEC: dynamtic check DMA desc buff type Greg Ungerer
2013-03-04 4:35 ` Frank Li
2013-03-04 5:06 ` Greg Ungerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).