* [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings
@ 2013-03-05 1:02 Shuah Khan
2013-03-05 1:28 ` Larry Finger
0 siblings, 1 reply; 3+ messages in thread
From: Shuah Khan @ 2013-03-05 1:02 UTC (permalink / raw)
To: brudley, arend, frankyl, linville, seth.forshee, pieterpg
Cc: linux-wireless, brcm80211-dev-list, netdev, LKML, shuahkhan
PCI_BUS defined in defs.h results in warnings from all brcm80211 source files
including defs.h. This define is not used in brcm80211. Removing this define
fixes the warning.
In file included from drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:35:0:
drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
CC [M] drivers/net/wireless/b43legacy/dma.o
CC [M] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o
CC [M] drivers/net/wireless/b43legacy/pio.o
In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
Signed-off-by: Shuah Khan <shuah.khan@hp.com>
---
drivers/net/wireless/brcm80211/include/defs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/brcm80211/include/defs.h b/drivers/net/wireless/brcm80211/include/defs.h
index fb7cbcf..3608436 100644
--- a/drivers/net/wireless/brcm80211/include/defs.h
+++ b/drivers/net/wireless/brcm80211/include/defs.h
@@ -20,7 +20,6 @@
#include <linux/types.h>
#define SI_BUS 0
-#define PCI_BUS 1
#define PCMCIA_BUS 2
#define SDIO_BUS 3
#define JTAG_BUS 4
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings
2013-03-05 1:02 [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings Shuah Khan
@ 2013-03-05 1:28 ` Larry Finger
2013-03-05 4:08 ` Shuah Khan
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2013-03-05 1:28 UTC (permalink / raw)
To: shuah.khan
Cc: brudley, arend, frankyl, linville, seth.forshee, pieterpg,
linux-wireless, brcm80211-dev-list, netdev, LKML, shuahkhan
On 03/04/2013 07:02 PM, Shuah Khan wrote:
> PCI_BUS defined in defs.h results in warnings from all brcm80211 source files
> including defs.h. This define is not used in brcm80211. Removing this define
> fixes the warning.
>
> In file included from drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:35:0:
> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
> include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
> CC [M] drivers/net/wireless/b43legacy/dma.o
> CC [M] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o
> CC [M] drivers/net/wireless/b43legacy/pio.o
> In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
> include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
> In file included from drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS" redefined [enabled by default]
> include/uapi/linux/pci.h:36:0: note: this is the location of the previous definition
Strange, I do not see PCI_BUS defined anywhere in the include/ branch in either
3.8 or 3.9. In addition, I don't get these warnings. What is different in your
system?
Larry
>
> Signed-off-by: Shuah Khan <shuah.khan@hp.com>
> ---
> drivers/net/wireless/brcm80211/include/defs.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/wireless/brcm80211/include/defs.h b/drivers/net/wireless/brcm80211/include/defs.h
> index fb7cbcf..3608436 100644
> --- a/drivers/net/wireless/brcm80211/include/defs.h
> +++ b/drivers/net/wireless/brcm80211/include/defs.h
> @@ -20,7 +20,6 @@
> #include <linux/types.h>
>
> #define SI_BUS 0
> -#define PCI_BUS 1
> #define PCMCIA_BUS 2
> #define SDIO_BUS 3
> #define JTAG_BUS 4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings
2013-03-05 1:28 ` Larry Finger
@ 2013-03-05 4:08 ` Shuah Khan
0 siblings, 0 replies; 3+ messages in thread
From: Shuah Khan @ 2013-03-05 4:08 UTC (permalink / raw)
To: Larry Finger
Cc: shuah.khan, brudley, arend, frankyl, linville, seth.forshee,
pieterpg, linux-wireless, brcm80211-dev-list, netdev, LKML
On Mon, Mar 4, 2013 at 6:28 PM, Larry Finger <Larry.Finger@lwfinger.net> wrote:
> On 03/04/2013 07:02 PM, Shuah Khan wrote:
>>
>> PCI_BUS defined in defs.h results in warnings from all brcm80211 source
>> files
>> including defs.h. This define is not used in brcm80211. Removing this
>> define
>> fixes the warning.
>>
>> In file included from
>> drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c:35:0:
>> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS"
>> redefined [enabled by default]
>> include/uapi/linux/pci.h:36:0: note: this is the location of the previous
>> definition
>> CC [M] drivers/net/wireless/b43legacy/dma.o
>> CC [M] drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.o
>> CC [M] drivers/net/wireless/b43legacy/pio.o
>> In file included from
>> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
>> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS"
>> redefined [enabled by default]
>> include/uapi/linux/pci.h:36:0: note: this is the location of the previous
>> definition
>> In file included from
>> drivers/net/wireless/brcm80211/brcmfmac/bcmsdh.c:29:0:
>> drivers/net/wireless/brcm80211/include/defs.h:23:0: warning: "PCI_BUS"
>> redefined [enabled by default]
>> include/uapi/linux/pci.h:36:0: note: this is the location of the previous
>> definition
>
>
> Strange, I do not see PCI_BUS defined anywhere in the include/ branch in
> either 3.8 or 3.9. In addition, I don't get these warnings. What is
> different in your system?
>
> Larry
I am sorry. Please ignore this patch. I had a old commit for a change
I was working on
and I thought I undid the changes. My apologies for the noise.
-- Shuah
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-05 4:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-05 1:02 [PATCH] net/wireless/brcm80211: remove PCI_BUS define from defs.h to fix warnings Shuah Khan
2013-03-05 1:28 ` Larry Finger
2013-03-05 4:08 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).