netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* upgrade to 3.8.1 : BUG Scheduling while atomic in bonding driver:
@ 2013-03-07  8:52 Linda Walsh
  0 siblings, 0 replies; 9+ messages in thread
From: Linda Walsh @ 2013-03-07  8:52 UTC (permalink / raw)
  To: LKML, Linux Kernel Network Developers




I am *not* seeing the bug in 3.8.2 with the 2nd patch applied (in
addition to the first)...


Michael Wang wrote:
>
>
> And both bond_enslave() and bond_mii_monitor() are using bond_update_speed_duplex()
> with preempt disabled.
>
> Along with the changes in bond_enslave(), I think you also need this (untested):
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 11d01d6..9af143a 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2373,7 +2373,9 @@ static void bond_miimon_commit(struct bonding *bond)
>                                 bond_set_backup_slave(slave);
>                         }
>  
> +                       read_unlock(&bond->lock);
>                         bond_update_speed_duplex(slave);
> +                       read_lock(&bond->lock);
>  
>                         pr_info("%s: link status definitely up for interface %s, %u Mbps %s duplex.\n",
>                                 bond->dev->name, slave->dev->name,
>
>
> Regards,
> Michael Wang
>
>   
>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-03-07 14:59 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <513063B4.8070604@tlinx.org>
2013-03-01 16:24 ` upgrade to 3.8.1 : BUG Scheduling while atomic in bonding driver: Eric Dumazet
     [not found]   ` <51317FCF.1070400@tlinx.org>
2013-03-02  5:21     ` Linda Walsh
2013-03-07  5:51       ` Michael Wang
2013-03-07  7:05         ` Linda Walsh
2013-03-07  7:48           ` Michael Wang
2013-03-07  8:04           ` Michael Wang
     [not found]             ` <513854E6.9010709@tlinx.org>
2013-03-07  9:50               ` Michael Wang
2013-03-07 14:59                 ` Veaceslav Falico
2013-03-07  8:52 Linda Walsh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).