netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vlad Yasevich <vyasevic@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [RFC PATCH net-next 0/3] Allow bridge to function in non-promisc mode
Date: Thu, 07 Mar 2013 10:35:37 -0500	[thread overview]
Message-ID: <5138B3C9.4060404@redhat.com> (raw)
In-Reply-To: <CAOaVG17iZu3r9no5FtNU-6ZwW2UdR3QBE6O3EKm6-JXAmEyuyA@mail.gmail.com>

On 03/07/2013 02:19 AM, Stephen Hemminger wrote:
> I understand the desire to add more functionality, but in this case it
> would introduce lots more problems. STP would break and it doesn't seem to
> gain anything that can't be done by other means.
>
> Turning bridge into macvlan seems unnecessary. Combining apples and bananas
> doesn't always make a tasty smoothy, sometimes it is just a mess.
>
> Maybe adding a little more to macvlan to do what you want would be simpler.
>


It's not really a macvlan over the bridge.  I would agree that 
particular setup would be a bit odd.  This work enables VMs to manage
their mac addresses and to reduce the load on the host by keeping the
bridge in promisc mode.

Sadly, most kvm network configs still use bridging and have not 
transitioned to OVS.  macvlan has some limitations as well and I working
to address those, but there is a desire for non-promisc bridge.  In
this case VMs can manage their mac addresses and can write that data to
the bridge.

STP is not broken as STP uses multicast mac and we set IFF_ALLMULTI thus
continuing to receive and process STP BPDUs.

The one thing that would appear to suffer from this is VLAN reception, 
but the bridge does allow vlan config now and that would have to be 
configured if VMs wish to use vlans.

I am not changing default operation of the bridge.  Default is still 
promisc.  In fact, one can switch back and forth without any network 
outages.  This simply adds another mode the the bridge operation.

-vlad

  reply	other threads:[~2013-03-07 15:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-07  2:31 [RFC PATCH net-next 0/3] Allow bridge to function in non-promisc mode Vlad Yasevich
2013-03-07  2:31 ` [RFC PATCH net-next 1/3] bridge: Add mac_management sysfs interface Vlad Yasevich
2013-03-07  2:35   ` Vlad Yasevich
2013-03-07  2:31 ` [RFC PATCH net-next 2/3] bridge: Allow an ability to designate an uplink port Vlad Yasevich
2013-03-07  2:31 ` [RFC PATCH net-next 3/3] bridge: Implement IFF_UNICAST_FLT Vlad Yasevich
2013-03-07  3:10   ` John Fastabend
2013-03-07 15:08     ` Vlad Yasevich
2013-03-07  7:19 ` [RFC PATCH net-next 0/3] Allow bridge to function in non-promisc mode Stephen Hemminger
2013-03-07 15:35   ` Vlad Yasevich [this message]
2013-03-07 17:13     ` Stephen Hemminger
2013-03-07 17:21       ` Vlad Yasevich
2013-03-07 17:38       ` Vlad Yasevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5138B3C9.4060404@redhat.com \
    --to=vyasevic@redhat.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).