From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
To: stefanr@s5r6.in-berlin.de, linux1394-devel@lists.sourceforge.net
Cc: netdev@vger.kernel.org
Subject: [RFC net-next 11/11] firewire net: Release broadcast/fifo resources on ifdown.
Date: Fri, 08 Mar 2013 10:45:57 +0900 [thread overview]
Message-ID: <513942D5.8050404@linux-ipv6.org> (raw)
Since those resources are allocated on ifup, relsase them on ifdown.
Signed-off-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
---
drivers/firewire/net.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index ca41446..c1898ad 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -1295,9 +1295,12 @@ out:
/* ifdown */
static int fwnet_stop(struct net_device *net)
{
+ struct fwnet_device *dev = netdev_priv(net);
+
netif_stop_queue(net);
- /* Deallocate iso context for use by other applications? */
+ fwnet_broadcast_stop(dev);
+ fwnet_fifo_stop(dev);
return 0;
}
@@ -1638,9 +1641,6 @@ static int fwnet_remove(struct device *_dev)
if (list_empty(&dev->peer_list)) {
unregister_netdev(net);
- fwnet_fifo_stop(dev);
- fwnet_broadcast_stop(dev);
-
for (i = 0; dev->queued_datagrams && i < 5; i++)
ssleep(1);
WARN_ON(dev->queued_datagrams);
--
1.7.9.5
reply other threads:[~2013-03-08 1:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513942D5.8050404@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).