* [PATCH net-next v3 3/4] ipv6: stop multicast forwarding to process interface scoped addresses
@ 2013-03-07 21:05 Hannes Frederic Sowa
2013-03-08 2:19 ` YOSHIFUJI Hideaki
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Frederic Sowa @ 2013-03-07 21:05 UTC (permalink / raw)
To: netdev; +Cc: yoshfuji
v2:
a) used struct ipv6_addr_props
v3:
a) reverted changes for ipv6_addr_props
Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
---
net/ipv6/ip6_input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
index b1876e5..b73bcc2 100644
--- a/net/ipv6/ip6_input.c
+++ b/net/ipv6/ip6_input.c
@@ -281,7 +281,7 @@ int ip6_mc_input(struct sk_buff *skb)
* IPv6 multicast router mode is now supported ;)
*/
if (dev_net(skb->dev)->ipv6.devconf_all->mc_forwarding &&
- !(ipv6_addr_type(&hdr->daddr) & IPV6_ADDR_LINKLOCAL) &&
+ !__ipv6_addr_needs_scope_id((ipv6_addr_type(&hdr->daddr))) &&
likely(!(IP6CB(skb)->flags & IP6SKB_FORWARDED))) {
/*
* Okay, we try to forward - split and duplicate
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v3 3/4] ipv6: stop multicast forwarding to process interface scoped addresses
2013-03-07 21:05 [PATCH net-next v3 3/4] ipv6: stop multicast forwarding to process interface scoped addresses Hannes Frederic Sowa
@ 2013-03-08 2:19 ` YOSHIFUJI Hideaki
0 siblings, 0 replies; 2+ messages in thread
From: YOSHIFUJI Hideaki @ 2013-03-08 2:19 UTC (permalink / raw)
To: netdev, David Miller, Hannes Frederic Sowa; +Cc: YOSHIFUJI Hideaki
Hannes Frederic Sowa wrote:
> v2:
> a) used struct ipv6_addr_props
>
> v3:
> a) reverted changes for ipv6_addr_props
>
> Cc: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
> Signed-off-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
> ---
> net/ipv6/ip6_input.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/ipv6/ip6_input.c b/net/ipv6/ip6_input.c
> index b1876e5..b73bcc2 100644
> --- a/net/ipv6/ip6_input.c
> +++ b/net/ipv6/ip6_input.c
> @@ -281,7 +281,7 @@ int ip6_mc_input(struct sk_buff *skb)
> * IPv6 multicast router mode is now supported ;)
> */
> if (dev_net(skb->dev)->ipv6.devconf_all->mc_forwarding &&
> - !(ipv6_addr_type(&hdr->daddr) & IPV6_ADDR_LINKLOCAL) &&
> + !__ipv6_addr_needs_scope_id((ipv6_addr_type(&hdr->daddr))) &&
> likely(!(IP6CB(skb)->flags & IP6SKB_FORWARDED))) {
> /*
> * Okay, we try to forward - split and duplicate
>
Well, I think __ipv6_addr_needs_scope_id() should be used just for
filling "sin6_scope_id", not for forwarding decision.
Since we always have multicast address, so
!(ipv6_addr_type(&hdr->daddr) & (IPV6_ADDR_LOOPBACK|IPV6_ADDR_LINKLOCAL))
is just fine for disallow "forwarding" multicast for interface-local addresses.
--yoshfuji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-03-08 2:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07 21:05 [PATCH net-next v3 3/4] ipv6: stop multicast forwarding to process interface scoped addresses Hannes Frederic Sowa
2013-03-08 2:19 ` YOSHIFUJI Hideaki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).