* [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len
@ 2013-03-08 11:03 Thomas Graf
2013-03-08 16:31 ` YOSHIFUJI Hideaki
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Graf @ 2013-03-08 11:03 UTC (permalink / raw)
To: davem; +Cc: netdev, Hideaki YOSHIFUJI
send_sllao is already initialized with the value of dev->addr_len
Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Signed-off-by: Thomas Graf <tgraf@suug.ch>
---
net/ipv6/ndisc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
index 76ef435..2712ab2 100644
--- a/net/ipv6/ndisc.c
+++ b/net/ipv6/ndisc.c
@@ -610,8 +610,6 @@ void ndisc_send_rs(struct net_device *dev, const struct in6_addr *saddr,
}
}
#endif
- if (!dev->addr_len)
- send_sllao = 0;
if (send_sllao)
optlen += ndisc_opt_addr_space(dev);
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len
2013-03-08 11:03 [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len Thomas Graf
@ 2013-03-08 16:31 ` YOSHIFUJI Hideaki
2013-03-08 17:30 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: YOSHIFUJI Hideaki @ 2013-03-08 16:31 UTC (permalink / raw)
To: davem; +Cc: Thomas Graf, netdev, YOSHIFUJI Hideaki
Thomas Graf wrote:
> send_sllao is already initialized with the value of dev->addr_len
>
> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
> Signed-off-by: Thomas Graf <tgraf@suug.ch>
> ---
> net/ipv6/ndisc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c
> index 76ef435..2712ab2 100644
> --- a/net/ipv6/ndisc.c
> +++ b/net/ipv6/ndisc.c
> @@ -610,8 +610,6 @@ void ndisc_send_rs(struct net_device *dev, const struct in6_addr *saddr,
> }
> }
> #endif
> - if (!dev->addr_len)
> - send_sllao = 0;
> if (send_sllao)
> optlen += ndisc_opt_addr_space(dev);
>
>
Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len
2013-03-08 16:31 ` YOSHIFUJI Hideaki
@ 2013-03-08 17:30 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2013-03-08 17:30 UTC (permalink / raw)
To: yoshfuji; +Cc: tgraf, netdev
From: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Date: Sat, 09 Mar 2013 01:31:53 +0900
> Thomas Graf wrote:
>> send_sllao is already initialized with the value of dev->addr_len
>>
>> Cc: Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
>> Signed-off-by: Thomas Graf <tgraf@suug.ch>
...
>>
> Acked-by: YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-03-08 17:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-08 11:03 [PATCH net-next] ipv6: ndisc: remove redundant check for !dev->addr_len Thomas Graf
2013-03-08 16:31 ` YOSHIFUJI Hideaki
2013-03-08 17:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).