From: Alexander Holler <holler@ahsoftware.de>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: Lubomir Rintel <lkundrak@v3.sk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Lubomir Rintel <lubo.rintel@gooddata.com>
Subject: Re: [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown
Date: Tue, 12 Mar 2013 12:36:11 +0100 [thread overview]
Message-ID: <513F132B.4060606@ahsoftware.de> (raw)
In-Reply-To: <513EEF83.9070806@ahsoftware.de>
Am 12.03.2013 10:04, schrieb Alexander Holler:
> I don't think so. Internally the driver calls mv643xx_eth_stop()
> therefore lockdep issues almost the same warning as when the interface
> is shut down (see below). And reading the code, I haven't seen how a
Btw. I consider the shutdown of the interface for just changing the MTU
more a problem than that lockdep-warning.
E.g. I had serious problems with dhcpcd which sets the MTU to 1500 when
an interface appears. What then happened was the following:
(1) interface comes up
(2) dhcpcd sets MTU to 1500
(3) a different MTU comes through DHCP
(4) driver shuts down if, sets MTU, turns on IF
back to (1) (endless loop)
I'm not sure if dhcpcd still does that (it's some time since I
discovered and reported that), but I consider it a crude way to shut
down the IF to set the MTU.
Regards,
Alexander
prev parent reply other threads:[~2013-03-12 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 14:07 [PATCH] mv643xx_eth: Fix a possible deadlock upon ifdown Lubomir Rintel
2013-01-04 14:17 ` Lubomir Rintel
2013-01-04 23:20 ` David Miller
2013-01-04 20:25 ` Lennert Buytenhek
2013-03-01 17:30 ` Alexander Holler
2013-03-12 2:49 ` Lennert Buytenhek
2013-03-12 9:04 ` Alexander Holler
2013-03-12 11:36 ` Alexander Holler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513F132B.4060606@ahsoftware.de \
--to=holler@ahsoftware.de \
--cc=buytenh@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=lubo.rintel@gooddata.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).