From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net-next v5 7/9] ipv6: allow ping to link-local address in VRF Date: Wed, 7 Nov 2018 12:07:56 -0700 Message-ID: <513f0145-2265-184a-41ad-49a844c946a7@gmail.com> References: <20181107153610.7526-1-mmanning@vyatta.att-mail.com> <20181107153610.7526-8-mmanning@vyatta.att-mail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Mike Manning , netdev@vger.kernel.org Return-path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:33743 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726440AbeKHEjj (ORCPT ); Wed, 7 Nov 2018 23:39:39 -0500 Received: by mail-pg1-f196.google.com with SMTP id q5-v6so7717710pgv.0 for ; Wed, 07 Nov 2018 11:07:58 -0800 (PST) In-Reply-To: <20181107153610.7526-8-mmanning@vyatta.att-mail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 11/7/18 8:36 AM, Mike Manning wrote: > If link-local packets are marked as enslaved to a VRF, then to allow > ping to the link-local from a vrf, the error handling for IPV6_PKTINFO > needs to be relaxed to also allow the pkt ipi6_ifindex to be that of a > slave device to the vrf. > > Note that the real device also needs to be retrieved in icmp6_iif() > to set the ipv6 flow oif to this for icmp echo reply handling. The > recent commit 24b711edfc34 ("net/ipv6: Fix linklocal to global address > with VRF") takes care of this, so the sdif does not need checking here. > > This fix makes ping to link-local consistent with that to global > addresses, in that this can now be done from within the same VRF that > the address is in. > > Signed-off-by: Mike Manning > --- > net/ipv6/ipv6_sockglue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern Tested-by: David Ahern