From: "Denis V. Lunev" <den@parallels.com>
To: Li Wei <lw@cn.fujitsu.com>
Cc: "Denis V. Lunev" <den@openvz.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, Tingwei Liu <tingw.liu@gmail.com>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
Subject: Re: [PATCH 1/1] ipv4: fix definition of FIB_TABLE_HASHSZ
Date: Wed, 13 Mar 2013 13:27:55 +0400 [thread overview]
Message-ID: <5140469B.3050708@parallels.com> (raw)
In-Reply-To: <514043CE.2080607@cn.fujitsu.com>
On 3/13/13 1:15 PM, Li Wei wrote:
> On 03/13/2013 04:43 PM, Denis V. Lunev wrote:
>> From: "Denis V. Lunev" <den@openvz.org>
>>
>> a long time ago by the commit
>>
>> commit 93456b6d7753def8760b423ac6b986eb9d5a4a95
>> Author: Denis V. Lunev <den@openvz.org>
>> Date: Thu Jan 10 03:23:38 2008 -0800
>>
>> [IPV4]: Unify access to the routing tables.
>>
>> the defenition of FIB_HASH_TABLE size has obtained wrong dependency:
>> it should depend upon CONFIG_IP_MULTIPLE_TABLES (as was in the original
>> code) but it was depended from CONFIG_IP_ROUTE_MULTIPATH
>>
>> This patch returns the situation to the original state.
>>
>> The problem was spotted by Tingwei Liu.
>>
>> Signed-off-by: Denis V. Lunev <den@openvz.org>
>> CC: Tingwei Liu <tingw.liu@gmail.com>
>> CC: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
>> ---
>> include/net/ip_fib.h | 12 +++++-------
>> 1 files changed, 5 insertions(+), 7 deletions(-)
>>
>> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
>> index 9497be1..3b12d5c 100644
>> --- a/include/net/ip_fib.h
>> +++ b/include/net/ip_fib.h
>> @@ -152,18 +152,16 @@ struct fib_result_nl {
>> };
>>
>> #ifdef CONFIG_IP_ROUTE_MULTIPATH
>> -
>> #define FIB_RES_NH(res) ((res).fi->fib_nh[(res).nh_sel])
>> -
>> -#define FIB_TABLE_HASHSZ 2
>> -
>> #else /* CONFIG_IP_ROUTE_MULTIPATH */
>> -
>> #define FIB_RES_NH(res) ((res).fi->fib_nh[0])
>> +#endif /* CONFIG_IP_ROUTE_MULTIPATH */
>>
>> +#ifdef CONFIG_IP_ROUTE_MULTIPLE_TABLES
>> +#define FIB_TABLE_HASHSZ 2
>> +#else
>> #define FIB_TABLE_HASHSZ 256
>> -
>> -#endif /* CONFIG_IP_ROUTE_MULTIPATH */
>> +#endif
> With CONFIG_IP_ROUTE_MULTIPLE_TABLES defined we use a smaller FIB_TABLE_HASHSZ ?
>
> Thanks.
pfff :((( I have mistaken once again. Thank you for pointing this out.
I'll resend the patch.
>>
>> extern __be32 fib_info_update_nh_saddr(struct net *net, struct fib_nh *nh);
>>
>>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2013-03-13 9:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 8:43 [PATCH 1/1] ipv4: fix definition of FIB_TABLE_HASHSZ Denis V. Lunev
2013-03-13 9:15 ` Li Wei
2013-03-13 9:27 ` Denis V. Lunev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140469B.3050708@parallels.com \
--to=den@parallels.com \
--cc=davem@davemloft.net \
--cc=den@openvz.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=lw@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=tingw.liu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox