From: Vlad Yasevich <vyasevic@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org
Subject: Re: [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc mode
Date: Wed, 13 Mar 2013 11:44:25 -0400 [thread overview]
Message-ID: <51409ED9.5080304@redhat.com> (raw)
In-Reply-To: <20130313083843.411b3a6c@nehalam.linuxnetplumber.net>
On 03/13/2013 11:38 AM, Stephen Hemminger wrote:
> On Tue, 12 Mar 2013 21:45:23 -0400
> Vlad Yasevich <vyasevic@redhat.com> wrote:
>
>> Add an sysfs interface to turn promiscusous mode on and off on
>> the bridge. By default all interfaces in the bridge
>> are in promisc mode. When promisc mode is turned off, it is
>> turned off on all bridge ports and the bridge turns on IFF_ALLMULTI
>> to handle multicast traffic.
>>
>> Signed-off-by: Vlad Yasevich <vyasevic@redhat.com>
>> ---
>> net/bridge/br_device.c | 41 +++++++++++++++++++++++++++++++++++++++++
>> net/bridge/br_if.c | 22 +++++++++++++++++-----
>> net/bridge/br_private.h | 2 ++
>> net/bridge/br_sysfs_br.c | 17 +++++++++++++++++
>> 4 files changed, 77 insertions(+), 5 deletions(-)
>>
>
> All attribute changes must also be available through netlink, and changes
> to attributes should cause a notification to applications listening for
> netlink events on that bridge.
>
There is currently no attribute for promisc vs non-promisc in the
bridge. Are you suggesting that this patch should add one?
-vlad
next prev parent reply other threads:[~2013-03-13 15:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 1:45 [PATCH net-next 0/4] Allow bridge to function in non-promisc mode Vlad Yasevich
2013-03-13 1:45 ` [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc mode Vlad Yasevich
2013-03-13 15:38 ` Stephen Hemminger
2013-03-13 15:44 ` Vlad Yasevich [this message]
2013-03-13 1:45 ` [PATCH net-next 2/4] bridge: Allow an ability to designate an uplink port Vlad Yasevich
2013-03-13 20:33 ` Michael S. Tsirkin
2013-03-13 22:54 ` Stephen Hemminger
2013-03-13 23:43 ` Vlad Yasevich
2013-03-14 14:53 ` Dan Williams
2013-03-13 1:45 ` [PATCH net-next 3/4] bridge: Implement IFF_UNICAST_FLT Vlad Yasevich
2013-03-13 1:45 ` [PATCH net-next 4/4] bridge: sync device list when a new uplink is designated Vlad Yasevich
2013-03-13 6:22 ` [PATCH net-next 0/4] Allow bridge to function in non-promisc mode "Oleg A. Arkhangelsky"
2013-03-13 12:12 ` Vlad Yasevich
2013-03-13 15:39 ` Stephen Hemminger
2013-03-13 15:45 ` Vlad Yasevich
2013-03-13 16:09 ` Stephen Hemminger
2013-03-13 17:04 ` Vlad Yasevich
2013-03-13 18:56 ` [Bridge] " Joel Wirāmu Pauling
2013-03-13 20:08 ` Michael S. Tsirkin
2013-03-13 20:31 ` Michael S. Tsirkin
2013-03-14 15:10 ` Vlad Yasevich
2013-03-14 17:46 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51409ED9.5080304@redhat.com \
--to=vyasevic@redhat.com \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).