From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlad Yasevich Subject: Re: [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc mode Date: Wed, 13 Mar 2013 11:44:25 -0400 Message-ID: <51409ED9.5080304@redhat.com> References: <1363139126-13396-1-git-send-email-vyasevic@redhat.com> <1363139126-13396-2-git-send-email-vyasevic@redhat.com> <20130313083843.411b3a6c@nehalam.linuxnetplumber.net> Reply-To: vyasevic@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org To: Stephen Hemminger Return-path: In-Reply-To: <20130313083843.411b3a6c@nehalam.linuxnetplumber.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: bridge-bounces@lists.linux-foundation.org Errors-To: bridge-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On 03/13/2013 11:38 AM, Stephen Hemminger wrote: > On Tue, 12 Mar 2013 21:45:23 -0400 > Vlad Yasevich wrote: > >> Add an sysfs interface to turn promiscusous mode on and off on >> the bridge. By default all interfaces in the bridge >> are in promisc mode. When promisc mode is turned off, it is >> turned off on all bridge ports and the bridge turns on IFF_ALLMULTI >> to handle multicast traffic. >> >> Signed-off-by: Vlad Yasevich >> --- >> net/bridge/br_device.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> net/bridge/br_if.c | 22 +++++++++++++++++----- >> net/bridge/br_private.h | 2 ++ >> net/bridge/br_sysfs_br.c | 17 +++++++++++++++++ >> 4 files changed, 77 insertions(+), 5 deletions(-) >> > > All attribute changes must also be available through netlink, and changes > to attributes should cause a notification to applications listening for > netlink events on that bridge. > There is currently no attribute for promisc vs non-promisc in the bridge. Are you suggesting that this patch should add one? -vlad