From: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset
Date: Wed, 13 Mar 2013 11:45:42 -0400 [thread overview]
Message-ID: <51409F26.6070100@signal11.us> (raw)
In-Reply-To: <D859EF9A-19A9-4F74-B59D-28FADBCE338A-G+tS6SCNB47quOJu9mQKZg@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1280 bytes --]
On 03/13/2013 10:40 AM, Wolf-Bastian Pöttner wrote:
> Nope. The patch fixes a problem in code that is not in mainline yet. However, people on the linux-zigbee mailing list found it a good idea to commit this change to mainline to avoid the problem from arising.
>
> I see, you disagree. Nevermind. ;)
Hi David,
This is my fault. I must have been looking the wrong tree when I
recommended a push to mainline.
Sorry for the noise.
Alan.
> Am 13.03.2013 um 15:38 schrieb David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>:
>> > From: Wolf-Bastian Pöttner <poettner-G+tS6SCNB47quOJu9mQKZg@public.gmane.org>
>> > Date: Wed, 13 Mar 2013 08:50:54 +0100
>> >
>>> >> offset has to be initialized, otherwise the *first* fragment will
>>> >> be discarded and reassembly cannot happen.
>>> >>
>>> >> Reviewed-by: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>
>> >
>> > 'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset)
>> > succeeds, in which case it will be initialized properly. Otherwise we
>> > unlock and drop the SKB and make no references whatsoever to 'offset'.
>> >
>> > I suspect you saw some compiler warning about 'offset' being
>> > uninitialized, and are just blindly trying to shut this warning up.
>
[-- Attachment #1.2: Type: text/html, Size: 3615 bytes --]
[-- Attachment #2: Type: text/plain, Size: 238 bytes --]
------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_mar
[-- Attachment #3: Type: text/plain, Size: 213 bytes --]
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
prev parent reply other threads:[~2013-03-13 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-13 7:50 [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset Wolf-Bastian Pöttner
2013-03-13 14:38 ` David Miller
2013-03-13 14:40 ` Wolf-Bastian Pöttner
[not found] ` <D859EF9A-19A9-4F74-B59D-28FADBCE338A-G+tS6SCNB47quOJu9mQKZg@public.gmane.org>
2013-03-13 15:45 ` Alan Ott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51409F26.6070100@signal11.us \
--to=alan-yzvjwurpmd1zbrfiqnyvsa@public.gmane.org \
--cc=Linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).