From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Ott Subject: Re: [PATCH] net/ieee802154/6lowpan: Fix initialization for fragment offset Date: Wed, 13 Mar 2013 11:45:42 -0400 Message-ID: <51409F26.6070100@signal11.us> References: <1363161054-13471-1-git-send-email-poettner@ibr.cs.tu-bs.de> <20130313.103830.247889330240632952.davem@davemloft.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1287764834906770095==" Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: David Miller Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-zigbee-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: netdev.vger.kernel.org This is a multi-part message in MIME format. --===============1287764834906770095== Content-Type: multipart/alternative; boundary="------------000208030905020704050700" This is a multi-part message in MIME format. --------------000208030905020704050700 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/13/2013 10:40 AM, Wolf-Bastian P=F6ttner wrote: > Nope. The patch fixes a problem in code that is not in mainline yet. Ho= wever, people on the linux-zigbee mailing list found it a good idea to co= mmit this change to mainline to avoid the problem from arising. > > I see, you disagree. Nevermind. ;) Hi David, This is my fault. I must have been looking the wrong tree when I recommended a push to mainline. Sorry for the noise. Alan. > Am 13.03.2013 um 15:38 schrieb David Miller : >> > From: Wolf-Bastian P=F6ttner >> > Date: Wed, 13 Mar 2013 08:50:54 +0100 >> >=20 >>> >> offset has to be initialized, otherwise the *first* fragment will >>> >> be discarded and reassembly cannot happen. >>> >>=20 >>> >> Reviewed-by: Alan Ott >> >=20 >> > 'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset) >> > succeeds, in which case it will be initialized properly. Otherwise = we >> > unlock and drop the SKB and make no references whatsoever to 'offset= '. >> >=20 >> > I suspect you saw some compiler warning about 'offset' being >> > uninitialized, and are just blindly trying to shut this warning up. > --------------000208030905020704050700 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit
On 03/13/2013 10:40 AM, Wolf-Bastian Pöttner wrote:
Nope. The patch fixes a problem in code that is not in mainline yet. However, people on the linux-zigbee mailing list found it a good idea to commit this change to mainline to avoid the problem from arising.

I see, you disagree. Nevermind. ;)

Hi David,

This is my fault. I must have been looking the wrong tree when I recommended a push to mainline.

Sorry for the noise.

Alan.

Am 13.03.2013 um 15:38 schrieb David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>:


> From: Wolf-Bastian Pöttner <poettner-G+tS6SCNB47quOJu9mQKZg@public.gmane.org>
> Date: Wed, 13 Mar 2013 08:50:54 +0100
> 

>> offset has to be initialized, otherwise the *first* fragment will
>> be discarded and reassembly cannot happen.
>> 
>> Reviewed-by: Alan Ott <alan-yzvJWuRpmD1zbRFIqnYvSA@public.gmane.org>

> 
> 'offset' is never used unless lowpan_fetch_skb_u8(skb, &offset)
> succeeds, in which case it will be initialized properly.  Otherwise we
> unlock and drop the SKB and make no references whatsoever to 'offset'.
> 
> I suspect you saw some compiler warning about 'offset' being
> uninitialized, and are just blindly trying to shut this warning up.


--------------000208030905020704050700-- --===============1287764834906770095== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_mar --===============1287764834906770095== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel --===============1287764834906770095==--