From: Chris Friesen <chris.friesen@genband.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Bill Fink <billfink@mindspring.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Thomas Graf <tgraf@suug.ch>, Vimal <j.vimal@gmail.com>,
netdev@vger.kernel.org, shemminger <shemminger@vyatta.com>
Subject: Re: [PATCH] Rate should be u64 to avoid integer overflow at high speeds (>= ~35Gbit)
Date: Wed, 13 Mar 2013 10:57:42 -0600 [thread overview]
Message-ID: <5140B006.500@genband.com> (raw)
In-Reply-To: <20130313083400.2329e982@nehalam.linuxnetplumber.net>
On 03/13/2013 09:34 AM, Stephen Hemminger wrote:
> As others have said the multiplier shift approach is a not a workable
> solution because it is likely to cause too many compatibility surprises.
> Older kernels would ignore the multiplier and therefore not give the users
> the effective rate they wanted.
How is that any different than ignoring the 64-bit value and not giving
the effective rate they wanted?
Chris
next prev parent reply other threads:[~2013-03-13 16:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 3:20 [PATCH] Rate should be u64 to avoid integer overflow at high speeds (>= ~35Gbit) Vimalkumar
2013-03-10 4:03 ` Eric Dumazet
2013-03-10 4:53 ` Vimal
2013-03-10 5:05 ` Eric Dumazet
2013-03-10 5:49 ` Bill Fink
2013-03-10 5:54 ` Eric Dumazet
2013-03-12 14:29 ` Chris Friesen
2013-03-12 15:42 ` Thomas Graf
2013-03-12 15:44 ` Eric Dumazet
2013-03-12 15:53 ` Chris Friesen
2013-03-12 15:56 ` Chris Friesen
2013-03-13 6:01 ` Bill Fink
2013-03-13 6:13 ` Eric Dumazet
2013-03-13 15:29 ` Bill Fink
2013-03-13 15:34 ` Stephen Hemminger
2013-03-13 16:57 ` Chris Friesen [this message]
2013-03-14 4:08 ` Bill Fink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5140B006.500@genband.com \
--to=chris.friesen@genband.com \
--cc=billfink@mindspring.com \
--cc=eric.dumazet@gmail.com \
--cc=j.vimal@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=stephen@networkplumber.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).