From: Jacob Keller <jacob.e.keller@intel.com>
To: Harshitha Ramamurthy <hramamurthy@google.com>, <netdev@vger.kernel.org>
Cc: <joshwash@google.com>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <willemb@google.com>, <ziweixiao@google.com>,
<jordanrhee@google.com>, <nktgrg@google.com>,
<kuozhao@google.com>, <yangchun@google.com>,
<awogbemila@google.com>, <maolson@google.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <sdf@fomichev.me>,
<bpf@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<stable@vger.kernel.com>, Debarghya Kundu <debarghyak@google.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH net 1/2] gve: Fix stats report corruption on queue count change
Date: Tue, 3 Feb 2026 17:41:50 -0800 [thread overview]
Message-ID: <5147b618-cc2e-4edb-8e9c-978c48f2dd55@intel.com> (raw)
In-Reply-To: <20260202193925.3106272-2-hramamurthy@google.com>
On 2/2/2026 11:39 AM, Harshitha Ramamurthy wrote:
> From: Debarghya Kundu <debarghyak@google.com>
>
> The driver and the NIC share a region in memory for stats reporting.
> The NIC calculates its offset into this region based on the total size
> of the stats region and the size of the NIC's stats.
>
> When the number of queues is changed, the driver's stats region is
> resized. If the queue count is increased, the NIC can write past
> the end of the allocated stats region, causing memory corruption.
> If the queue count is decreased, there is a gap between the driver
> and NIC stats, leading to incorrect stats reporting.
>
> This change fixes the issue by allocating stats region with maximum
> size, and the offset calculation for NIC stats is changed to match
> with the calculation of the NIC.
>
> Cc: stable@vger.kernel.org
> Fixes: 24aeb56f2d38 ("gve: Add Gvnic stats AQ command and ethtool show/set-priv-flags.")
> Signed-off-by: Debarghya Kundu <debarghyak@google.com>
> Reviewed-by: Joshua Washington <joshwash@google.com>
> Signed-off-by: Harshitha Ramamurthy <hramamurthy@google.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2026-02-04 1:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 19:39 [PATCH net 0/2] gve: Stats reporting fixes Harshitha Ramamurthy
2026-02-02 19:39 ` [PATCH net 1/2] gve: Fix stats report corruption on queue count change Harshitha Ramamurthy
2026-02-04 1:41 ` Jacob Keller [this message]
2026-02-02 19:39 ` [PATCH net 2/2] gve: Correct ethtool rx_dropped calculation Harshitha Ramamurthy
2026-02-04 1:42 ` Jacob Keller
2026-02-04 3:40 ` [PATCH net 0/2] gve: Stats reporting fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5147b618-cc2e-4edb-8e9c-978c48f2dd55@intel.com \
--to=jacob.e.keller@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=awogbemila@google.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=debarghyak@google.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hramamurthy@google.com \
--cc=john.fastabend@gmail.com \
--cc=jordanrhee@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=kuozhao@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maolson@google.com \
--cc=netdev@vger.kernel.org \
--cc=nktgrg@google.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=stable@vger.kernel.com \
--cc=stable@vger.kernel.org \
--cc=willemb@google.com \
--cc=yangchun@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox