From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com,
edumazet@google.com
Subject: Re: [PATCH net-next 2/2] net: reset transport header if it was not set before transmission
Date: Tue, 19 Mar 2013 17:26:45 +0800 [thread overview]
Message-ID: <51482F55.8020900@redhat.com> (raw)
In-Reply-To: <20130317.121318.1869489921021513474.davem@davemloft.net>
On 03/18/2013 12:13 AM, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Fri, 15 Mar 2013 19:10:51 -0700
>
>> Any way we can avoid adding this to fast path, for people not using
>> macvtap and ixgbe ?
> Likewise I'd rather see macvtap be responsible for fixing this up by
> setting the transport header properly, and therfore sending well
> formed packets to the rest of the stack.
Ok, haven't checked all other possibility but looks like packet needs to
be fixed also.
next prev parent reply other threads:[~2013-03-19 9:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 7:41 [PATCH net-next 1/2] net_sched: don't do precise pkt_len computation for untrusted packets Jason Wang
2013-03-15 7:41 ` [PATCH net-next 2/2] net: reset transport header if it was not set before transmission Jason Wang
2013-03-16 2:10 ` Eric Dumazet
2013-03-17 16:13 ` David Miller
2013-03-19 9:26 ` Jason Wang [this message]
2013-03-19 12:13 ` Eric Dumazet
2013-03-19 12:58 ` Daniel Borkmann
2013-03-19 12:59 ` Eric Dumazet
2013-03-19 13:52 ` Daniel Borkmann
2013-03-17 16:10 ` [PATCH net-next 1/2] net_sched: don't do precise pkt_len computation for untrusted packets David Miller
2013-03-19 9:25 ` Jason Wang
2013-03-19 12:10 ` Eric Dumazet
2013-03-19 12:58 ` Eric Dumazet
2013-03-20 6:19 ` Jason Wang
2013-03-20 13:46 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51482F55.8020900@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).