Re: [PATCH v2 net-next 1/4] flow_keys: include thoff into flow_keys for later usage

[Daniel Borkmann <dborkman@redhat.com>]

On 03/19/2013 04:03 PM, Eric Dumazet wrote:
> On Tue, 2013-03-19 at 15:34 +0100, Daniel Borkmann wrote:
>> In skb_flow_dissect(), we perform a dissection of a skbuff. Since we're
>> doing the work here anyway, also store thoff for a later usage, e.g. in
>> the BPF filter. Also, by having thoff 16 Bit, we do not need to pack
>> flow_keys and reorder choke_skb_cb.
>>
>> Suggested-by: Eric Dumazet <edumazet@google.com>
>> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
>> ---
>>   This patch also needs to go into the net tree, since Eric or Jason will
>>   post a bug fix on top of this one.
>>
>>   include/net/flow_keys.h   | 1 +
>>   net/core/flow_dissector.c | 5 ++++-
>>   2 files changed, 5 insertions(+), 1 deletion(-)
>
> Oh well, you left the choke_skb_cb description in changelog

But it's not the old changelog. ;-)

  Also, by having thoff 16 Bit, we do *not* need to pack flow_keys and
  reorder choke_skb_cb.

> Acked-by: Eric Dumazet <edumazet@google.com>