From: Mugunthan V N <mugunthanvnm@ti.com>
To: David Miller <davem@davemloft.net>
Cc: <aeschlimann@gmail.com>, <khc@pm.waw.pl>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<c.aeschlimann@acn-group.ch>
Subject: Re: [PATCH] ixp4xx_eth: set the device dma_coherent_mask
Date: Tue, 19 Mar 2013 22:34:25 +0530 [thread overview]
Message-ID: <51489A99.2030107@ti.com> (raw)
In-Reply-To: <20130319.123359.2245221095583640859.davem@davemloft.net>
On 3/19/2013 10:03 PM, David Miller wrote:
> From: Christophe Aeschlimann<aeschlimann@gmail.com>
> Date: Tue, 19 Mar 2013 16:59:25 +0100
>
>> >Without the mask it is impossible to take the network interface up
>> >since it returns the following error:
>> >
>>> >>net eth1: coherent DMA mask is unset
>>> >>ifconfig: SIOCSIFFLAGS: Cannot allocate memory
>> >
>> >Tested on an out-of-tree ixp425 based board.
>> >
>> >Signed-off-by: Christophe Aeschlimann<c.aeschlimann@acn-group.ch>
> ...
>> >@@ -1398,6 +1398,7 @@ static int eth_init_one(struct platform_device *pdev)
>> > return -ENOMEM;
>> >
>> > SET_NETDEV_DEV(dev, &pdev->dev);
>> >+ dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
> Hmmm, shouldn't this be the default value, set by the bus layer or
> similar?
bus layer or any platform code doesn't init this value. The same issue
applies
to CPSW driver also. Previously the same was done in board or device
file. But
this approach is obsolete now, need to think of how it can be resolved in DT
approach
Regards
Mugunthan V N
next prev parent reply other threads:[~2013-03-19 17:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 15:59 [PATCH] ixp4xx_eth: set the device dma_coherent_mask Christophe Aeschlimann
2013-03-19 16:33 ` David Miller
2013-03-19 17:04 ` Mugunthan V N [this message]
2013-03-19 22:35 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51489A99.2030107@ti.com \
--to=mugunthanvnm@ti.com \
--cc=aeschlimann@gmail.com \
--cc=c.aeschlimann@acn-group.ch \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).