From: Daniel Borkmann <dborkman@redhat.com>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
eric.dumazet@gmail.com, jasowang@redhat.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 4/4] filter: add minimal BPF JIT emitted image disassembler
Date: Wed, 20 Mar 2013 09:50:41 +0100 [thread overview]
Message-ID: <51497861.6020804@redhat.com> (raw)
In-Reply-To: <1363748314.31336.30.camel@deadeye.wl.decadent.org.uk>
On 03/20/2013 03:58 AM, Ben Hutchings wrote:
> On Tue, 2013-03-19 at 14:28 +0100, Daniel Borkmann wrote:
>> This is a minimal stand-alone user space helper, that allows for debugging or
>> verification of emitted BPF JIT images. This is in particular useful for
>> emitted opcode debugging, since minor bugs in the JIT compiler can be fatal.
>> The disassembler is architecture generic and uses libopcodes and libbfd.
> [...]
>> ---
>> scripts/bpf_jit_disasm.c | 216 +++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 216 insertions(+)
>> create mode 100644 scripts/bpf_jit_disasm.c
> [...]
>
> This might belong in tools. scripts is mostly for build scripts now.
Ok, I thought this would be overkill, since it's just a small C program
(unlike perf, etc) and there are also other things present in scripts/
like Coccinelle scripts etc. But, sure we could do this. What would you
suggest? tools/net/bpf_jit_disasm.c?
prev parent reply other threads:[~2013-03-20 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-19 13:28 [PATCH net-next 0/4] net: filter: BPF updates Daniel Borkmann
2013-03-19 13:28 ` [PATCH net-next 1/4] flow_keys: include thoff into flow_keys for later usage Daniel Borkmann
2013-03-19 13:55 ` Eric Dumazet
2013-03-19 14:01 ` Daniel Borkmann
2013-03-19 13:28 ` [PATCH net-next 2/4] net: flow_dissector: add __skb_get_poff to get a start offset to payload Daniel Borkmann
2013-03-19 13:28 ` [PATCH net-next 3/4] filter: add ANC_PAY_OFFSET instruction for loading payload start offset Daniel Borkmann
2013-03-19 13:28 ` [PATCH net-next 4/4] filter: add minimal BPF JIT emitted image disassembler Daniel Borkmann
2013-03-20 2:58 ` Ben Hutchings
2013-03-20 8:50 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51497861.6020804@redhat.com \
--to=dborkman@redhat.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=jasowang@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).