From: David Daney <ddaney.cavm@gmail.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
David Daney <ddaney@caviumnetworks.com>
Subject: Re: [PATCH 5/5] net: mdio-octeon: Use module_platform_driver()
Date: Wed, 20 Mar 2013 09:12:38 -0700 [thread overview]
Message-ID: <5149DFF6.1010304@gmail.com> (raw)
In-Reply-To: <1363779692-4395-5-git-send-email-sachin.kamat@linaro.org>
On 03/20/2013 04:41 AM, Sachin Kamat wrote:
> module_platform_driver macro removes some boilerplate and
> simplifies the code.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: David Daney <ddaney@caviumnetworks.com>
I was going to send the equivalent patch.
Acked-by: David Daney <ddaney@caviumnetworks.com>
> ---
> drivers/net/phy/mdio-octeon.c | 13 +------------
> 1 files changed, 1 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-octeon.c b/drivers/net/phy/mdio-octeon.c
> index 09297fe..c2c878d 100644
> --- a/drivers/net/phy/mdio-octeon.c
> +++ b/drivers/net/phy/mdio-octeon.c
> @@ -197,18 +197,7 @@ void octeon_mdiobus_force_mod_depencency(void)
> }
> EXPORT_SYMBOL(octeon_mdiobus_force_mod_depencency);
>
> -static int __init octeon_mdiobus_mod_init(void)
> -{
> - return platform_driver_register(&octeon_mdiobus_driver);
> -}
> -
> -static void __exit octeon_mdiobus_mod_exit(void)
> -{
> - platform_driver_unregister(&octeon_mdiobus_driver);
> -}
> -
> -module_init(octeon_mdiobus_mod_init);
> -module_exit(octeon_mdiobus_mod_exit);
> +module_platform_driver(octeon_mdiobus_driver);
>
> MODULE_DESCRIPTION(DRV_DESCRIPTION);
> MODULE_VERSION(DRV_VERSION);
>
next prev parent reply other threads:[~2013-03-20 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 11:41 [PATCH 1/5] net: ks8695net: Use module_platform_driver() Sachin Kamat
2013-03-20 11:41 ` [PATCH 2/5] net: s6gmac: " Sachin Kamat
2013-03-20 17:26 ` David Miller
2013-03-20 11:41 ` [PATCH 3/5] net: au1k_ir: " Sachin Kamat
2013-03-20 17:26 ` David Miller
2013-03-20 11:41 ` [PATCH 4/5] net: mdio-gpio: " Sachin Kamat
2013-03-20 17:26 ` David Miller
2013-03-20 11:41 ` [PATCH 5/5] net: mdio-octeon: " Sachin Kamat
2013-03-20 16:12 ` David Daney [this message]
2013-03-20 17:26 ` David Miller
2013-03-20 17:25 ` [PATCH 1/5] net: ks8695net: " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5149DFF6.1010304@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=davem@davemloft.net \
--cc=ddaney@caviumnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).