From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH net-next] net: fix psock_fanout selftest hash collision Date: Thu, 21 Mar 2013 07:31:34 +0100 Message-ID: <514AA946.6020603@redhat.com> References: <1363761764-4374-1-git-send-email-willemb@google.com> <20130320.123344.1566685302188091721.davem@davemloft.net> <20130320.135934.156565403641352244.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: David Miller , netdev@vger.kernel.org To: Willem de Bruijn Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62206 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755067Ab3CUGbj (ORCPT ); Thu, 21 Mar 2013 02:31:39 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 03/21/2013 01:07 AM, Willem de Bruijn wrote: > On Wed, Mar 20, 2013 at 1:59 PM, David Miller wrote: >> From: David Miller >> Date: Wed, 20 Mar 2013 12:33:44 -0400 (EDT) >> >>> From: Willem de Bruijn >>> Date: Wed, 20 Mar 2013 02:42:44 -0400 >>> >>>> Fix flaky results with PACKET_FANOUT_HASH depending on whether the >>>> two flows hash into the same packet socket or not. >>>> >>>> Also adds tests for PACKET_FANOUT_LB and PACKET_FANOUT_CPU and >>>> replaces the counting method with a packet ring. >>>> >>>> Signed-off-by: Willem de Bruijn >>> >>> Applied, thanks. I'll retest on my sparc64 box later today. >> >> Unfortunately, it's still broken there: > > This looks like a new problem. Now the counters all stay zero. > > I am looking into it. I have not been able to reproduce this on my > x86_64 so far, so just brought a sparc32 up in qemu. Had less luck > with sparc64, but impressive that it works at all. Come to think of > it, is this a 64-bit kernel with 32-bit userland? Perhaps that > affects packet ring memory layout. That can affect the ring buffer in case of TPACKET_V1, which is default if not specified otherwise. See Documentation/networking/packet_mmap.txt +514